Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update orderBy documentation to include using multiple calls for multiple columns #546

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ismailnagib
Copy link

Knex.js supports using multiple orderBy calls to use multiple columns in the SQL ORDER BY clause. This pull request adds an example of this behavior to the documentation, to show that such a method is indeed supported by Knex.js.

This is a link to a unit test from the Knex.js repository demonstrating this behavior:
https://github.com/knex/knex/blob/master/test/unit/query/builder.js#L3434-L3456

@ismailnagib
Copy link
Author

Hi @OlivierCavadenti, I'm not sure if it's okay for me to mention you, but it seems that you're the one who merged the previous PRs. Please kindly take a look, it's only 2 lines of changes. Thank you!

@rluvaton
Copy link
Member

rluvaton commented Mar 2, 2024

The website repo has been moved inside the https://github.com/knex/knex repo. Please open a PR there instead: (the website will be under the docs folder)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants