Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove me from rabbitmq-eventing maintainers #1624

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

Zerpet
Copy link
Contributor

@Zerpet Zerpet commented Oct 23, 2024

Changes

  • 🗑️ Remove me from the project

/kind removal

Unfortunately, I have to withdraw from the project and focus in other project.

@knative-prow knative-prow bot added the kind/removal Categorizes issue or PR as related to removing dead code, or deprecated apis/features. label Oct 23, 2024
Copy link

linux-foundation-easycla bot commented Oct 23, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Zerpet / name: Aitor Pérez Cedres (05e7438)
  • ✅ login: dsimansk / name: David Simansky (2ae35ca)

@knative-prow knative-prow bot requested review from aliok and dsimansk October 23, 2024 12:31
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 23, 2024
@dsimansk
Copy link
Contributor

@Zerpet sad news.

To drop yourself from approvers, you will need to remote this entry: https://github.com/knative/community/blob/main/peribolos/knative-extensions.yaml#L1041

and then run ./hack/update-codege.sh to regen owners files.

@@ -152,7 +152,6 @@ orgs:
- yuvalif
- yuzisun
- zainabhusain227
- Zerpet
Copy link
Contributor

@dsimansk dsimansk Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line will effectively remove you from Knative gh org, if that's also desired. Then, you want to do the same on knative-extensions.yaml. But that's solely on your decision AFAIK.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is ok. I don't think I'll get time to contribute to this community any time soon 😔

@Zerpet
Copy link
Contributor Author

Zerpet commented Oct 23, 2024

@Zerpet sad news.

To drop yourself from approvers, you will need to remote this entry: https://github.com/knative/community/blob/main/peribolos/knative-extensions.yaml#L1041

and then run ./hack/update-codege.sh to regen owners files.

I think I did it right this time 🥲

@dsimansk
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2024
Copy link

knative-prow bot commented Oct 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, Zerpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2024
@knative-prow knative-prow bot merged commit f222a6e into knative:main Oct 23, 2024
6 checks passed
@Zerpet Zerpet deleted the update-code-owners-alias branch October 23, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/removal Categorizes issue or PR as related to removing dead code, or deprecated apis/features. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants