Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Github admin teams and drop TOC review reminder #1613

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Edit Github admin teams and drop TOC review reminder #1613

merged 4 commits into from
Oct 15, 2024

Conversation

psschwei
Copy link
Contributor

@psschwei psschwei commented Sep 23, 2024 •
edited
Loading

Changes

As TOC was folded into Steering in #1587 , moving the former TOC members into the Steering github team.

We also no longer need to post reminders about the TOC review meetings.

/cc @knative/steering-committee @knative/technical-oversight-committee

@psschwei
drop TOC review reminder
5aad4be 
Signed-off-by: Paul S. Schweigert <[email protected]>
@knative-prow Knative Prow
Copy link

knative-prow bot commented Sep 23, 2024

@psschwei: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

As TOC was folded into Steering in #1587 , we no longer need to post reminders about the TOC meetings.

/cc @knative/steering-committee @knative/technical-oversight-committee

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot requested review from a team September 23, 2024 13:04
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 23, 2024
@psschwei
update github teams for steering/toc
24bf377 
Signed-off-by: Paul S. Schweigert <[email protected]>
@psschwei psschwei changed the title Drop TOC review reminder Edit Github admin teams and drop TOC review reminder Sep 23, 2024
aliok
aliok reviewed Sep 24, 2024
View reviewed changes
Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

Holding for productivity team review, if necessary.

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2024
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2024
@dprotaso
Copy link
Member

/lgtm

dprotaso
dprotaso reviewed Sep 24, 2024
View reviewed changes
.github/workflows/toc-review-reminder.yaml Outdated
@@ -1,59 +0,0 @@
# Copyright 2024 The Knative Authors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe disable the job - might be worth discussing if steering wants to continue this practice

@psschwei
disable wg review action
b67cf6f 
Signed-off-by: Paul S. Schweigert <[email protected]>
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2024
@psschwei
actually disable wg review
960df4a 
Signed-off-by: Paul S. Schweigert <[email protected]>
@knative-prow Knative Prow
Copy link

knative-prow bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 24, 2024
@dprotaso
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2024
@dsimansk
Copy link
Contributor

/lgtm

@psschwei
Copy link
Contributor Author

Think we can drop the hold here, but will wait a day or so in case @knative/productivity-reviewers think otherwise

@psschwei
Copy link
Contributor Author

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2024
@knative-prow knative-prow bot merged commit 5e78386 into knative:main Oct 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprotaso dprotaso dprotaso left review comments

@aliok aliok aliok left review comments

Assignees

@dprotaso dprotaso

@aliok aliok

@dsimansk dsimansk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@psschwei @dprotaso @dsimansk @aliok