Skip to content

Commit

Permalink
Fix various misspellings and linter items (#1057)
Browse files Browse the repository at this point in the history
* spelling: additional

Signed-off-by: Josh Soref <[email protected]>

* spelling: bindings

Signed-off-by: Josh Soref <[email protected]>

* spelling: blocked

Signed-off-by: Josh Soref <[email protected]>

* spelling: bootstrap

Signed-off-by: Josh Soref <[email protected]>

* spelling: channel

Signed-off-by: Josh Soref <[email protected]>

* spelling: channel

Signed-off-by: Josh Soref <[email protected]>

* spelling: commands

Signed-off-by: Josh Soref <[email protected]>

* spelling: comparison

Signed-off-by: Josh Soref <[email protected]>

* spelling: configuration

Signed-off-by: Josh Soref <[email protected]>

* spelling: controller

Signed-off-by: Josh Soref <[email protected]>

* spelling: convert

Signed-off-by: Josh Soref <[email protected]>

* spelling: desired

Signed-off-by: Josh Soref <[email protected]>

* spelling: dynamic

Signed-off-by: Josh Soref <[email protected]>

* spelling: entry

Signed-off-by: Josh Soref <[email protected]>

* spelling: execute

Signed-off-by: Josh Soref <[email protected]>

* spelling: explicit

Signed-off-by: Josh Soref <[email protected]>

* spelling: hardcoded

Signed-off-by: Josh Soref <[email protected]>

* spelling: information

Signed-off-by: Josh Soref <[email protected]>

* spelling: inject

Signed-off-by: Josh Soref <[email protected]>

* spelling: item

Signed-off-by: Josh Soref <[email protected]>

* spelling: kubectl

Signed-off-by: Josh Soref <[email protected]>

* spelling: latest

Signed-off-by: Josh Soref <[email protected]>

* spelling: message

Signed-off-by: Josh Soref <[email protected]>

* spelling: namespace

Signed-off-by: Josh Soref <[email protected]>

* spelling: namespaces

Signed-off-by: Josh Soref <[email protected]>

* spelling: output

Signed-off-by: Josh Soref <[email protected]>

* spelling: overriding

Signed-off-by: Josh Soref <[email protected]>

* spelling: parameters

Signed-off-by: Josh Soref <[email protected]>

* spelling: revision

Signed-off-by: Josh Soref <[email protected]>

* spelling: separated

Signed-off-by: Josh Soref <[email protected]>

* spelling: separator

Signed-off-by: Josh Soref <[email protected]>

* spelling: service

Signed-off-by: Josh Soref <[email protected]>

* spelling: specified

Signed-off-by: Josh Soref <[email protected]>

* spelling: specifies

Signed-off-by: Josh Soref <[email protected]>

* spelling: splitting

Signed-off-by: Josh Soref <[email protected]>

* spelling: subscription

Signed-off-by: Josh Soref <[email protected]>

* spelling: trigger

Signed-off-by: Josh Soref <[email protected]>

* spelling: unknown

Signed-off-by: Josh Soref <[email protected]>

* spelling: unstructured

Signed-off-by: Josh Soref <[email protected]>

* spelling: workflow

Signed-off-by: Josh Soref <[email protected]>

* chore: Address golinter complaint for (c *MockKnServingClient) GetBaseRevision

Signed-off-by: Josh Soref <[email protected]>

* chore: update changelog for spelling fixes (#1057)
  • Loading branch information
jsoref authored Oct 13, 2020
1 parent f7ddef5 commit 4939c5e
Show file tree
Hide file tree
Showing 43 changed files with 68 additions and 63 deletions.
2 changes: 1 addition & 1 deletion .github/pull-request-template.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
Fixes #

<!--
Please add an entrty to CHANGELOG.adoc file, too, as part of your Pull Request.
Please add an entry to CHANGELOG.adoc file, too, as part of your Pull Request.
In the following cases, add a short description of PR to the unreleased section in CHANGELOG.adoc:
Expand Down
7 changes: 6 additions & 1 deletion CHANGELOG.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@
|===
| | Description | PR

| 🐛
| Fix various misspellings and linter items
| https://github.com/knative/client/pull/1057[#1057]


| 🎁
| Add Aliases to Help Command and Remove Aliases in Short
| https://github.com/knative/client/pull/1055[#1055]
Expand Down Expand Up @@ -352,7 +357,7 @@
| https://github.com/knative/client/pull/819[#819]

| 🐛
| Update help messsage for `kn source apiserver` to reflect the new API
| Update help message for `kn source apiserver` to reflect the new API
| https://github.com/knative/client/pull/817[#817]

| 🐛
Expand Down
4 changes: 2 additions & 2 deletions cmd/kn/main_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,9 @@ func TestUnknownCommands(t *testing.T) {
expectedError []string
}{
{
[]string{"service", "udpate", "test", "--scale-min=0"},
[]string{"service", "unknown", "test", "--scale-min=0"},
[]string{"service"},
[]string{"unknown sub-command", "udpate"},
[]string{"unknown sub-command", "unknown"},
},
{
[]string{"service", "--foo=bar"},
Expand Down
2 changes: 1 addition & 1 deletion conventions/cli.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ be used:
- `create` creates a resource.
- `update` updates a resource.
- `delete` deletes a resource.
- `apply` for an idempotent "create-or-update", much like `kubetl apply`
- `apply` for an idempotent "create-or-update", much like `kubectl apply`

For a given resource, create and update should use the same arguments as much as
possible and where it makes sense.
Expand Down
2 changes: 1 addition & 1 deletion conventions/client.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ find the digest of the resolved image for the revision.

If an client does not set the revision name, the client may find the
`status.latestCreatedRevision` field useful, even though using it is subject to
a race condition, if the client compares the relevant informatin on the found
a race condition, if the client compares the relevant information on the found
revision to the template. For example, if the image on the template matches the
`latestCreatedRevision`'s image, the client is justified in using the
`status.imageDigest` field from the revision.
Expand Down
2 changes: 1 addition & 1 deletion docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ Below are the options you can specify in the `kn` config file.
plugins. It can be any directory that is visible to the user.

2. `lookupPluginsInPath` which is the same as the persistent flag
`--lookup-plugins-in-path` and specficies if `kn` should look for plugins
`--lookup-plugins-in-path` and specifies if `kn` should look for plugins
anywhere in the specified `PATH` environment variable. This is a boolean
configuration option and the default value is `false`.

Expand Down
2 changes: 1 addition & 1 deletion docs/cmd/kn_service_create.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ kn service create NAME --image IMAGE
--async DEPRECATED: please use --no-wait instead. Do not wait for 'service create' operation to be completed.
--autoscale-window string Duration to look back for making auto-scaling decisions. The service is scaled to zero if no request was received in during that time. (eg: 10s)
--cluster-local Specify that the service be private. (--no-cluster-local will make the service publicly available)
--cmd string Specify command to be used as entrypoint instead of default one. Example: --cmd /app/start or --cmd /app/start --arg myArg to pass aditional arguments.
--cmd string Specify command to be used as entrypoint instead of default one. Example: --cmd /app/start or --cmd /app/start --arg myArg to pass additional arguments.
--concurrency-limit int Hard Limit of concurrent requests to be processed by a single replica.
--concurrency-target int Recommendation for when to scale up based on the concurrent number of incoming request. Defaults to --concurrency-limit when given.
--concurrency-utilization int Percentage of concurrent requests utilization before scaling up. (default 70)
Expand Down
2 changes: 1 addition & 1 deletion docs/cmd/kn_service_update.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ kn service update NAME
--async DEPRECATED: please use --no-wait instead. Do not wait for 'service update' operation to be completed.
--autoscale-window string Duration to look back for making auto-scaling decisions. The service is scaled to zero if no request was received in during that time. (eg: 10s)
--cluster-local Specify that the service be private. (--no-cluster-local will make the service publicly available)
--cmd string Specify command to be used as entrypoint instead of default one. Example: --cmd /app/start or --cmd /app/start --arg myArg to pass aditional arguments.
--cmd string Specify command to be used as entrypoint instead of default one. Example: --cmd /app/start or --cmd /app/start --arg myArg to pass additional arguments.
--concurrency-limit int Hard Limit of concurrent requests to be processed by a single replica.
--concurrency-target int Recommendation for when to scale up based on the concurrent number of incoming request. Defaults to --concurrency-limit when given.
--concurrency-utilization int Percentage of concurrent requests utilization before scaling up. (default 70)
Expand Down
2 changes: 1 addition & 1 deletion docs/cmd/kn_source_binding_list.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ kn source binding list

```
# List all sink binidngs
# List all sink bindings
kn source binding list
# List all sink bindings in YAML format
Expand Down
2 changes: 1 addition & 1 deletion docs/operations/autoscaling.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

The Knative Pod Autoscaler (KPA), provides fast, request-based autoscaling
capabilities. To correctly configure autoscaling to zero for revisions, you must
modify its paramenters.
modify its parameters.

`target` defines how many concurrent requests are wanted at a given time (soft
limit) and is the recommended configuration for autoscaling in Knative.
Expand Down
2 changes: 1 addition & 1 deletion docs/workflows/basic.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Basic Workflow

In this basic worflow we show the CRUD (create, read, update, delete) operations
In this basic workflow we show the CRUD (create, read, update, delete) operations
on a service. We use a well known
[simple Hello World service](https://github.com/knative/docs/tree/master/docs/serving/samples/hello-world/helloworld-go)
that reads the environment variable `TARGET` and prints it as output.
Expand Down
2 changes: 1 addition & 1 deletion lib/test/capture_output.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
// doSomeActionThatWritesToStdOutAndStdErr()
// stdOut, stdErr := capture.Close()
//
// CaptureOutpu() and capture.Close() should always come in pairs as Close() also
// CaptureOutput() and capture.Close() should always come in pairs as Close() also
// restores the old streams
package test

Expand Down
10 changes: 5 additions & 5 deletions lib/test/cli.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ import (
)

const (
seperatorHeavy = "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━"
seperatorLight = "╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍"
separatorHeavy = "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━"
separatorLight = "╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍"
)

// Kn type
Expand Down Expand Up @@ -159,10 +159,10 @@ func dumpService(namespace string, args []string) string {

// Service info
appendResourceInfo(&buffer, "ksvc", name, namespace)
fmt.Fprintf(&buffer, "%s\n", seperatorHeavy)
fmt.Fprintf(&buffer, "%s\n", separatorHeavy)
// Service's configuration
appendResourceInfo(&buffer, "configuration", name, namespace)
fmt.Fprintf(&buffer, "%s\n", seperatorHeavy)
fmt.Fprintf(&buffer, "%s\n", separatorHeavy)
// Get all revisions for this service
appendResourceInfoWithNameSelector(&buffer, "revision", name, namespace, "serving.knative.dev/service")
// Get all routes for this service
Expand Down Expand Up @@ -218,7 +218,7 @@ func appendResourceInfoWithNameSelector(buffer *bytes.Buffer, kind string, name

out, err := RunKubectl(namespace, argsDescribe...)
appendCLIOutput(buffer, fmt.Sprintf("kubectl describe %s %s --namespace %s%s", kind, name, namespace, extra), out, err)
fmt.Fprintf(buffer, "%s\n", seperatorLight)
fmt.Fprintf(buffer, "%s\n", separatorLight)
out, err = RunKubectl(namespace, argsGet...)
appendCLIOutput(buffer, fmt.Sprintf("kubectl get %s %s --namespace %s -oyaml%s", kind, name, namespace, extra), out, err)
}
Expand Down
4 changes: 2 additions & 2 deletions lib/test/integration.go
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ func GetNextServiceName(base string) string {
return base + strconv.Itoa(current)
}

// CreateNamespace creates and tests a namesspace creation invoking kubectl
// CreateNamespace creates and tests a namespace creation invoking kubectl
func CreateNamespace(namespace string) error {
expectedOutputRegexp := fmt.Sprintf("namespace?.+%s.+created", namespace)
out, err := createNamespaceWithRetry(namespace, MaxRetries)
Expand All @@ -132,7 +132,7 @@ func CreateNamespace(namespace string) error {
return nil
}

// DeleteNamespace deletes and tests a namesspace deletion invoking kubectl
// DeleteNamespace deletes and tests a namespace deletion invoking kubectl
func DeleteNamespace(namespace string) error {
kubectl := Kubectl{namespace}
out, err := kubectl.Run("delete", "namespace", namespace)
Expand Down
2 changes: 1 addition & 1 deletion lib/test/result_collector.go
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ func (c *KnRunResultCollector) printCommands(out io.Writer) {
for i, result := range c.results {
c.printCommand(out, result)
if i < len(c.results)-1 {
fmt.Fprintf(out, "┣━%s\n", seperatorHeavy)
fmt.Fprintf(out, "┣━%s\n", separatorHeavy)
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/dynamic/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ func (c *knDynamicClient) ListChannelsUsingGVKs(gvks *[]schema.GroupVersionKind,

gvr := gvk.GroupVersion().WithResource(strings.ToLower(gvk.Kind) + "s")

// list objects of chaneel type with this GVR
// list objects of channel type with this GVR
cList, err := c.client.Resource(gvr).Namespace(namespace).List(context.TODO(), options)
if err != nil {
return nil, err
Expand Down
4 changes: 2 additions & 2 deletions pkg/dynamic/client_mock.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ type MockKnDynamicClient struct {
recorder *ClientRecorder
}

// NewMockKnDyanmicClient returns a new mock instance which you need to record for
func NewMockKnDyanmicClient(t *testing.T, ns ...string) *MockKnDynamicClient {
// NewMockKnDynamicClient returns a new mock instance which you need to record for
func NewMockKnDynamicClient(t *testing.T, ns ...string) *MockKnDynamicClient {
namespace := "default"
if len(ns) > 0 {
namespace = ns[0]
Expand Down
2 changes: 1 addition & 1 deletion pkg/dynamic/client_mock_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import (

func TestMockKnDynamicClient(t *testing.T) {

client := NewMockKnDyanmicClient(t)
client := NewMockKnDynamicClient(t)

recorder := client.Recorder()

Expand Down
2 changes: 1 addition & 1 deletion pkg/kn/commands/flags/sink.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ func (i *SinkFlags) AddWithFlagName(cmd *cobra.Command, fname, short string) {
"If a prefix is not provided, it is considered as a Knative service."

for _, p := range config.GlobalConfig.SinkMappings() {
//user configration might override the default configuration
//user configuration might override the default configuration
sinkMappings[p.Prefix] = schema.GroupVersionResource{
Resource: p.Resource,
Group: p.Group,
Expand Down
4 changes: 2 additions & 2 deletions pkg/kn/commands/namespaced.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func AddNamespaceFlags(flags *pflag.FlagSet, allowAll bool) {
// GetNamespace returns namespace from command specified by flag
func (params *KnParams) GetNamespace(cmd *cobra.Command) (string, error) {
namespace := cmd.Flag("namespace").Value.String()
// check value of all-namepaces only if its defined
// check value of all-namespaces only if its defined
if cmd.Flags().Lookup("all-namespaces") != nil {
all, err := cmd.Flags().GetBool("all-namespaces")
if err != nil {
Expand All @@ -54,7 +54,7 @@ func (params *KnParams) GetNamespace(cmd *cobra.Command) (string, error) {
return "", nil
}
}
// if all-namepaces=False or namespace not given, use default namespace
// if all-namespaces=False or namespace not given, use default namespace
if namespace == "" {
var err error
namespace, err = params.CurrentNamespace()
Expand Down
2 changes: 1 addition & 1 deletion pkg/kn/commands/service/export.go
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ func constructServiceFromRevision(latestSvc *servingv1.Service, revision *servin
ObjectMeta: latestSvc.Spec.Template.ObjectMeta,
}

//ovrriding revision template annotations with revision annotations
//overriding revision template annotations with revision annotations
stripIgnoredAnnotationsFromRevision(revision)
exportedSvc.Spec.Template.ObjectMeta.Annotations = revision.ObjectMeta.Annotations

Expand Down
4 changes: 2 additions & 2 deletions pkg/kn/commands/service/human_readable_flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ func printKServiceList(kServiceList *servingv1.ServiceList, options hprinters.Pr
func printKService(kService *servingv1.Service, options hprinters.PrintOptions) ([]metav1beta1.TableRow, error) {
name := kService.Name
url := kService.Status.URL
lastestRevision := kService.Status.ConfigurationStatusFields.LatestReadyRevisionName
latestRevision := kService.Status.ConfigurationStatusFields.LatestReadyRevisionName
age := commands.TranslateTimestampSince(kService.CreationTimestamp)
conditions := commands.ConditionsValue(kService.Status.Conditions)
ready := commands.ReadyCondition(kService.Status.Conditions)
Expand All @@ -77,7 +77,7 @@ func printKService(kService *servingv1.Service, options hprinters.PrintOptions)
row.Cells = append(row.Cells,
name,
url,
lastestRevision,
latestRevision,
age,
conditions,
ready,
Expand Down
2 changes: 1 addition & 1 deletion pkg/kn/commands/service/update_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ func fakeServiceUpdate(original *servingv1.Service, args []string) (
return
}

func TestServcieUpdateNoFlags(t *testing.T) {
func TestServiceUpdateNoFlags(t *testing.T) {
orig := newEmptyService()

action, _, _, err := fakeServiceUpdate(orig, []string{"service", "update", "foo"})
Expand Down
2 changes: 1 addition & 1 deletion pkg/kn/commands/source/binding/list.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ func NewBindingListCommand(p *commands.KnParams) *cobra.Command {
Use: "list",
Short: "List sink bindings",
Example: `
# List all sink binidngs
# List all sink bindings
kn source binding list
# List all sink bindings in YAML format
Expand Down
2 changes: 1 addition & 1 deletion pkg/kn/commands/source/human_readable_flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ var sourceTypeDescription = map[string]string{
"ContainerSource": "Generate events by Container image and send to addressable",
// TODO: source plugin could bring the description that kn could look for based on the availability
// of the plugin and fetch the description from there, for now we dont have that capability in kn
// so we're shipping harcoded short description of the KafkaSource as below
// so we're shipping hardcoded short description of the KafkaSource as below
"KafkaSource": "Route events from Apache Kafka Server to addressable",
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/kn/commands/subscription/flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ func ListHandlers(h hprinters.PrintHandler) {
subscriptionColumnDefinitions := []metav1beta1.TableColumnDefinition{
{Name: "Namespace", Type: "string", Description: "Namespace of the subscription", Priority: 0},
{Name: "Name", Type: "string", Description: "Name of the subscription", Priority: 1},
{Name: "Channel", Type: "string", Description: "Channel of the subcription", Priority: 1},
{Name: "Channel", Type: "string", Description: "Channel of the subscription", Priority: 1},
{Name: "Subscriber", Type: "string", Description: "Subscriber sink of the subscription", Priority: 1},
{Name: "Reply", Type: "string", Description: "Reply sink of the subscription", Priority: 1},
{Name: "Dead Letter Sink", Type: "string", Description: "DeadLetterSink of the subscription", Priority: 1},
Expand Down
2 changes: 1 addition & 1 deletion pkg/kn/commands/trigger/create_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func TestTriggerWithInjectCreate(t *testing.T) {
eventingRecorder.Validate()
}

func TestTriggetWithInjecError(t *testing.T) {
func TestTriggerWithInjectError(t *testing.T) {
eventingClient := clienteventingv1beta1.NewMockKnEventingClient(t)
dynamicClient := dynamicfake.CreateFakeKnDynamicClient("default", &servingv1.Service{
TypeMeta: metav1.TypeMeta{Kind: "Service", APIVersion: "serving.knative.dev/v1"},
Expand Down
4 changes: 2 additions & 2 deletions pkg/kn/commands/version/version_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ func TestVersion(t *testing.T) {
BuildDate = fakeBuildDate
GitRevision = fakeGitRevision
knVersionObj = knVersion{fakeVersion, fakeBuildDate, fakeGitRevision, apiVersions}
expectedOutput = genVersionOuput(t, knVersionObj)
expectedOutput = genVersionOutput(t, knVersionObj)
knParams = &commands.KnParams{}
versionCmd = NewVersionCommand(knParams)
output = new(bytes.Buffer)
Expand Down Expand Up @@ -114,7 +114,7 @@ func TestVersion(t *testing.T) {

}

func genVersionOuput(t *testing.T, obj knVersion) string {
func genVersionOutput(t *testing.T, obj knVersion) string {
tmpl, err := template.New("versionOutput").Parse(versionOutputTemplate)
assert.NilError(t, err)
buf := bytes.Buffer{}
Expand Down
2 changes: 1 addition & 1 deletion pkg/kn/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ var globalConfig = config{}
// GlobalConfig is the global configuration available for every sub-command
var GlobalConfig Config = &globalConfig

// bootstrapConfig reads in config file and boostrap options if set.
// BootstrapConfig reads in config file and bootstrap options if set.
func BootstrapConfig() error {

// Create a new FlagSet for the bootstrap flags and parse those. This will
Expand Down
2 changes: 1 addition & 1 deletion pkg/kn/flags/channel_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ func (i *ChannelTypeFlags) Add(f *pflag.FlagSet) {
"Examples: '--type messaging.knative.dev:v1alpha1:KafkaChannel' for specifying explicit Group:Version:Kind.")

for _, p := range config.GlobalConfig.ChannelTypeMappings() {
//user configration might override the default configuration
//user configuration might override the default configuration
ctypeMappings[p.Alias] = schema.GroupVersionKind{
Kind: p.Kind,
Group: p.Group,
Expand Down
2 changes: 1 addition & 1 deletion pkg/kn/flags/podspec.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ func (p *PodSpecFlags) AddFlags(flagset *pflag.FlagSet) []string {

flagset.StringVarP(&p.Command, "cmd", "", "",
"Specify command to be used as entrypoint instead of default one. "+
"Example: --cmd /app/start or --cmd /app/start --arg myArg to pass aditional arguments.")
"Example: --cmd /app/start or --cmd /app/start --arg myArg to pass additional arguments.")
flagNames = append(flagNames, "cmd")

flagset.StringArrayVarP(&p.Arg, "arg", "", []string{},
Expand Down
2 changes: 1 addition & 1 deletion pkg/kn/plugin/manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ func NewManager(pluginDir string, lookupInPath bool) *Manager {

// FindPlugin checks if a plugin for the given parts exist and return it.
// The args given must not contain any options and contain only
// the comands (like in [ "source", "github" ] for a plugin called 'kn-source-github'
// the commands (like in [ "source", "github" ] for a plugin called 'kn-source-github'
// The plugin with the most specific (longest) name is returned or nil if non is found.
// An error is returned if the lookup fails for some reason like an io error
func (manager *Manager) FindPlugin(parts []string) (Plugin, error) {
Expand Down
2 changes: 1 addition & 1 deletion pkg/kn/traffic/compute.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ func newTarget(tag, revision string, percent int64, latestRevision bool) (target
if latestRevision {
target.LatestRevision = ptr.Bool(true)
} else {
// as LatestRevision and RevisionName can't be specfied together for a target
// as LatestRevision and RevisionName can't be specified together for a target
target.LatestRevision = ptr.Bool(false)
target.RevisionName = revision
}
Expand Down
Loading

0 comments on commit 4939c5e

Please sign in to comment.