Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the linting issues for min and max #269

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

houshengbo
Copy link
Contributor

@houshengbo houshengbo commented Jan 13, 2025

No description provided.

Copy link

knative-prow bot commented Jan 13, 2025

@houshengbo: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

knative-prow bot commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2025
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 13, 2025
@houshengbo houshengbo added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.55%. Comparing base (c1edfdb) to head (7fd60cb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #269   +/-   ##
=======================================
  Coverage   47.55%   47.55%           
=======================================
  Files          25       25           
  Lines        2675     2675           
=======================================
  Hits         1272     1272           
  Misses       1356     1356           
  Partials       47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2025
Copy link

knative-prow bot commented Jan 13, 2025

New changes are detected. LGTM label has been removed.

@houshengbo houshengbo added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2025
@knative-prow knative-prow bot merged commit 1353223 into knative-extensions:main Jan 13, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant