-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop non-KIngress Conformance Tests #424
Drop non-KIngress Conformance Tests #424
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @nak3 |
Codecov Report
@@ Coverage Diff @@
## main #424 +/- ##
===========================================
+ Coverage 16.45% 72.76% +56.31%
===========================================
Files 21 9 -12
Lines 3167 683 -2484
===========================================
- Hits 521 497 -24
+ Misses 2615 157 -2458
+ Partials 31 29 -2 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
/lgtm |
Description
Having these tests (using the gateway api directly) isn't necessary since we already have our KIngress tests which are ensuring we have the correct functionality. Plus it's a source of confusion
Changes
Closes