Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ekb to tagged version #369

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

dsimansk
Copy link
Contributor

Description

Changes

  • Update ekb to tagged version

I'll need to figure out issue with our auto-update tooling and some kn plugins.

@knative-prow knative-prow bot requested review from daisy-ycguo and rhuss January 27, 2025 11:34
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 27, 2025
@dsimansk
Copy link
Contributor Author

/cherry-pick release-1.17

@knative-prow-robot
Copy link

@dsimansk: once the present PR merges, I will cherry-pick it on top of release-1.17 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dsimansk
Copy link
Contributor Author

/cc @skonto

@knative-prow knative-prow bot requested a review from skonto January 27, 2025 11:34
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.98%. Comparing base (18d2618) to head (41cc4a7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #369   +/-   ##
=======================================
  Coverage   44.98%   44.98%           
=======================================
  Files          11       11           
  Lines         558      558           
=======================================
  Hits          251      251           
  Misses        292      292           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link

skonto commented Jan 27, 2025

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2025
Copy link

knative-prow bot commented Jan 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit bdeaabb into knative-extensions:main Jan 27, 2025
18 checks passed
@knative-prow-robot
Copy link

@dsimansk: new pull request created: #370

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants