-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the deadlock in the dispatcher #1369 #1370
Fix the deadlock in the dispatcher #1369 #1370
Conversation
Welcome @ckyoog! It looks like this is your first PR to knative-extensions/eventing-rabbitmq 🎉 |
/assign @ikavgo @Zerpet @mkuratczyk |
hey @ckyoog thanks for the PR. You'll have to sign the CLA - can you follow the instructions by clicking on the red boxes in this comment - #1370 (comment) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1370 +/- ##
==========================================
+ Coverage 63.16% 64.66% +1.49%
==========================================
Files 60 60
Lines 4333 3574 -759
==========================================
- Hits 2737 2311 -426
+ Misses 1481 1148 -333
Partials 115 115 ☔ View full report in Codecov by Sentry. |
closing and re-opening to refresh and get the latest github actions |
@ckyoog please look here - #1370 (comment) this email thingy prevents merge |
It occurs when the rabbitmq server is down while the dispatcher is waiting for the response from the subscriber.
531896f
to
f292c47
Compare
Hi I was using a wrong email address in the commits. I just corrected them. I am wondering, if I used the right email address in the first place, would I still need to sign the CLA? Just curious. |
/override "codecov/patch" |
@ikavgo: ikavgo unauthorized: /override is restricted to Repo administrators. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckyoog, ikavgo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override "codecov/patch" |
@dprotaso: Overrode contexts on behalf of dprotaso: codecov/patch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5e97d06
into
knative-extensions:main
It occurs when the rabbitmq server is down while the dispatcher is waiting for the response from the subscriber.
See #1369 for details.