Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the deadlock in the dispatcher #1369 #1370

Merged

Conversation

ckyoog
Copy link
Contributor

@ckyoog ckyoog commented Apr 4, 2024

It occurs when the rabbitmq server is down while the dispatcher is waiting for the response from the subscriber.

See #1369 for details.

Copy link

linux-foundation-easycla bot commented Apr 4, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@knative-prow knative-prow bot requested review from mkuratczyk and Zerpet April 4, 2024 19:26
Copy link

knative-prow bot commented Apr 4, 2024

Welcome @ckyoog! It looks like this is your first PR to knative-extensions/eventing-rabbitmq 🎉

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 4, 2024
@dprotaso
Copy link
Contributor

dprotaso commented Apr 5, 2024

/assign @ikavgo @Zerpet @mkuratczyk

@dprotaso
Copy link
Contributor

dprotaso commented Apr 5, 2024

hey @ckyoog thanks for the PR. You'll have to sign the CLA - can you follow the instructions by clicking on the red boxes in this comment - #1370 (comment)

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 64.66%. Comparing base (9b15d3b) to head (f292c47).
Report is 7 commits behind head on main.

Files Patch % Lines
pkg/dispatcher/dispatcher.go 11.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1370      +/-   ##
==========================================
+ Coverage   63.16%   64.66%   +1.49%     
==========================================
  Files          60       60              
  Lines        4333     3574     -759     
==========================================
- Hits         2737     2311     -426     
+ Misses       1481     1148     -333     
  Partials      115      115              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Contributor

dprotaso commented Apr 5, 2024

closing and re-opening to refresh and get the latest github actions

@dprotaso dprotaso closed this Apr 5, 2024
@dprotaso dprotaso reopened this Apr 5, 2024
@ikavgo ikavgo self-requested a review April 8, 2024 08:25
@ikavgo
Copy link
Contributor

ikavgo commented Apr 8, 2024

@ckyoog please look here - #1370 (comment) this email thingy prevents merge

ckyoog added 2 commits April 9, 2024 10:51
It occurs when the rabbitmq server is down while the dispatcher is
waiting for the response from the subscriber.
@ckyoog ckyoog force-pushed the fix-dispatcher-deadlock branch from 531896f to f292c47 Compare April 9, 2024 17:52
@ckyoog
Copy link
Contributor Author

ckyoog commented Apr 9, 2024

Hi I was using a wrong email address in the commits. I just corrected them. I am wondering, if I used the right email address in the first place, would I still need to sign the CLA? Just curious.

@ikavgo
Copy link
Contributor

ikavgo commented Apr 9, 2024

/override "codecov/patch"

Copy link

knative-prow bot commented Apr 9, 2024

@ikavgo: ikavgo unauthorized: /override is restricted to Repo administrators.

In response to this:

/override "codecov/patch"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2024
Copy link

knative-prow bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckyoog, ikavgo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2024
@dprotaso
Copy link
Contributor

dprotaso commented Apr 9, 2024

/override "codecov/patch"

Copy link

knative-prow bot commented Apr 9, 2024

@dprotaso: Overrode contexts on behalf of dprotaso: codecov/patch

In response to this:

/override "codecov/patch"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit 5e97d06 into knative-extensions:main Apr 9, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants