Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backported pkg files from release-1.10 #496

Closed
wants to merge 80 commits into from
Closed

backported pkg files from release-1.10 #496

wants to merge 80 commits into from

Conversation

astelmashenko
Copy link
Member

Fixes #489

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2024
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2024
@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 16, 2024
@astelmashenko
backported pkg files from release-1.10
b9cc5de
@astelmashenko
Merge remote-tracking branch 'origin/feature/backport-426-to-main' in…
db3101f 
…to feature/backport-426-to-main

# Conflicts:
#	pkg/channel/jetstream/dispatcher/dispatcher.go
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 70.34884% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 42.87%. Comparing base (b6a5e67) to head (5b77983).
Report is 41 commits behind head on main.

Files Patch % Lines
...channel/jetstream/dispatcher/message_dispatcher.go 71.55% 23 Missing and 10 partials ⚠️
pkg/channel/jetstream/dispatcher/consumer.go 0.00% 14 Missing ⚠️
pkg/channel/jetstream/utils/consumerconfig.go 85.71% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #496      +/-   ##
==========================================
- Coverage   45.32%   42.87%   -2.45%     
==========================================
  Files          30       61      +31     
  Lines        1966     2680     +714     
==========================================
+ Hits          891     1149     +258     
- Misses       1020     1453     +433     
- Partials       55       78      +23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astelmashenko astelmashenko marked this pull request as ready for review January 17, 2024 11:18
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2024
@knative-prow knative-prow bot requested review from aliok and pierDipi January 17, 2024 11:18
@astelmashenko
Copy link
Member Author

/assign @dan-j

knative-automation and others added 9 commits January 18, 2024 08:27
@knative-automation
upgrade to latest dependencies (knative-extensions#497)
237ba33 
bumping knative.dev/eventing 42af160...b0d9c13:
  > b0d9c13 Provision sequences CA cert in its status (# 7590)
  > a74bef1 rekt test to verify only one EventType created for MTBroker (# 7586)
  > d5c32db Set audience in .status.addresses fields too (# 7591)
  > 9648826 Increase KinD test timeout to 90 minutes (# 7585)
  > 580dc9b Updated test example to use actual test instead of hypothetical example (# 7579)
  > 58608b2 [main] Upgrade to latest dependencies (# 7580)
  > 598e866 New Event Filtering: Add rekt test for multiple filters (# 7574)
bumping knative.dev/reconciler-test eaf0b82...50276df:
  > 50276df upgrade to latest dependencies (# 654)
  > 4357f51 upgrade to latest dependencies (# 649)
bumping knative.dev/pkg f95090a...b488e7b:
  > b488e7b upgrade to latest dependencies (# 2938)

Signed-off-by: Knative Automation <[email protected]>
@knative-automation
Update community files (knative-extensions#498)
41892fd 
Signed-off-by: Knative Automation <[email protected]>
@creydr
Update to Golang 1.21 (knative-extensions#500)
f7b0c7f
@knative-automation
upgrade to latest dependencies (knative-extensions#499)
7cea97e 
bumping knative.dev/eventing b0d9c13...fd95228:
  > fd95228 Enable storage of EventType v1b2 (# 7594)
  > 6962251 Add a Prerequisite helper to check if the OIDC authentication feature flag is enabled (# 7609)
  > 341a8df [main] Update community files (# 7611)
  > bb5313d Remove OIDC service account, when OIDC feature is disabled again (# 7570)
  > 44ff98b Eventing TLS: Add scheme label to metrics (# 7581)
  > 8d6c6e4 Bump Go to v1.21 (# 7602)
  > 7cba45b Add TLS test for sequence (# 7600)
  > 01d8ace [main] Update community files (# 7601)
  > ad51fee Enable TLS for OIDC e2e tests (# 7551)
  > fb9be2b Authenticate requests from PingSources (# 7525)

Signed-off-by: Knative Automation <[email protected]>
@knative-automation
upgrade to latest dependencies (knative-extensions#501)
47bdd49 
bumping knative.dev/eventing fd95228...fd95228:
bumping knative.dev/hack/schema e89096d...f3f03ac:
  > f3f03ac [release-1.13] Don't hardcode serving as the repo when setting highest semver (# 362)
bumping knative.dev/hack e89096d...f3f03ac:
  > f3f03ac [release-1.13] Don't hardcode serving as the repo when setting highest semver (# 362)

Signed-off-by: Knative Automation <[email protected]>
@knative-automation
upgrade to latest dependencies (knative-extensions#502)
40d2ec9 
bumping google.golang.org/api b52e40b...ee5c9cc:
  > ee5c9cc chore(main): release 0.159.0 (# 2378)
  > 55b0516 fix(transport): relax universe checks (# 2376)
  > a8d9414 feat(all): auto-regenerate discovery clients (# 2377)
  > 68b1bc1 chore(main): release 0.158.0 (# 2360)
  > df17254 fix(transport/grpc): add universe domain verification (# 2375)
  > b21a1fa fix(internal): support internaloption.WithDefaultUniverseDomain (# 2373)
  > ddb3a12 chore(google-api-go-generator): replace literal with const (# 2363)
  > d266978 feat(all): auto-regenerate discovery clients (# 2374)
  > 73fc7fd fix(transport): not enable s2a when there is endpoint override (# 2368)
  > 2d69d97 feat(all): auto-regenerate discovery clients (# 2372)
  > 45c097f feat(all): auto-regenerate discovery clients (# 2369)
  > addc18c chore(all): update module github.com/google/go-github/v52 to v58 (# 2351)
  > a4e39d8 chore(all): update all to v0.47.0 (# 2367)
  > e0db6a5 feat(all): auto-regenerate discovery clients (# 2366)
  > f40db7f feat(all): auto-regenerate discovery clients (# 2365)
  > 69626e3 feat(transport): add universe domain support (# 2355)
  > 6c3b622 feat(all): auto-regenerate discovery clients (# 2361)
  > 6ef1144 feat(impersonate): add universe domain support (# 2296)
  > 6e77ef2 chore(main): release 0.157.0 (# 2346)
  > 72a8ffd feat(all): auto-regenerate discovery clients (# 2358)
  > 74a1558 docs(option): update WithDefaultEndpointTemplate docs (# 2356)
  > 135da01 chore(all): update all to a9fa171 (# 2350)
  > 0d002f9 feat(all): auto-regenerate discovery clients (# 2354)
  > da330c2 feat(all): auto-regenerate discovery clients (# 2353)
  > 5bf46ee feat(all): auto-regenerate discovery clients (# 2352)
  > 3bf8f4f feat(all): auto-regenerate discovery clients (# 2349)
  > 763c331 feat(all): auto-regenerate discovery clients (# 2348)
  > c3e43a1 feat(all): auto-regenerate discovery clients (# 2345)
  > d016573 chore(main): release 0.156.0 (# 2333)
  > 05de776 feat(all): auto-regenerate discovery clients (# 2344)
  > 811e925 feat(all): auto-regenerate discovery clients (# 2343)
  > 9e45101 feat(google-api-go-generator): add universe domain support (# 2335)
  > 3f90b98 feat(all): auto-regenerate discovery clients (# 2341)
  > 9745014 test: fix overflow (# 2342)
  > 3f8b548 chore(all): update all (# 2338)
  > c8905be chore(deps): bump github.com/cloudflare/circl from 1.3.3 to 1.3.7 in /internal/kokoro/discogen (# 2340)
  > d008b6e feat(all): auto-regenerate discovery clients (# 2339)
  > ceefb9b feat(all): auto-regenerate discovery clients (# 2337)
  > bd4dad1 feat(all): auto-regenerate discovery clients (# 2336)
  > 014a8e0 feat(all): auto-regenerate discovery clients (# 2332)
bumping knative.dev/reconciler-test 50276df...ab0a030:
  > ab0a030 upgrade to latest dependencies (# 661)
  > 1687b63 upgrade to latest dependencies (# 660)
  > 0fa3f10 added function to create standard global environment with the provided rest config (# 658)
  > 796f7dc upgrade to latest dependencies (# 657)
  > 546d310 Update community files (# 656)

Signed-off-by: Knative Automation <[email protected]>
@knative-automation
upgrade to latest dependencies (knative-extensions#503)
e9b4946 
bumping knative.dev/eventing 54f3952...02bde54:
  > 02bde54 Add helm as one of the development requirement (# 7643)
  > 56ee9b2 Add TLS tests for Trigger and Subscription dead letter sinks (# 7636)
  > ff52881 Use filtered informer to watch OIDC service accounts (# 7527)
bumping knative.dev/reconciler-test ab0a030...9a52608:
  > 9a52608 Update Golang to 1.21 (# 662)

Signed-off-by: Knative Automation <[email protected]>
@knative-automation
Update community files (knative-extensions#504)
4dbe41b 
Signed-off-by: Knative Automation <[email protected]>
@knative-automation
upgrade to latest dependencies (knative-extensions#505)
839fbbc 
bumping knative.dev/eventing 02bde54...62c74c1:
  > 62c74c1 [main] Update community files (# 7646)
  > 702004a Tiny trustbundle improvements (# 7644)
bumping knative.dev/reconciler-test 9a52608...feb27a7:
  > feb27a7 Update community files (# 663)
bumping knative.dev/pkg b6659cc...e85c3cf:
  > e85c3cf Update community files (# 2950)
bumping knative.dev/hack/schema ab9b690...f3881d9:
  > f3881d9 Update community files (# 364)
bumping knative.dev/hack ab9b690...f3881d9:
  > f3881d9 Update community files (# 364)

Signed-off-by: Knative Automation <[email protected]>
@dan-j
Copy link
Contributor

dan-j commented Apr 13, 2024

/lgtm
/approve

There is a small bug in both versions, but not going to stop merging this.. created a new issue #541 to track that

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Apr 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astelmashenko, dan-j

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [astelmashenko,dan-j]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dan-j
Copy link
Contributor

dan-j commented Apr 13, 2024

@astelmashenko Looks like one of the checks are failing on codecov: https://github.com/knative-extensions/eventing-natss/pull/496/checks?check_run_id=23785523290

@astelmashenko
Copy link
Member Author

@astelmashenko Looks like one of the checks are failing on codecov: https://github.com/knative-extensions/eventing-natss/pull/496/checks?check_run_id=23785523290

Yeah, I'll take a look at it.

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Apr 15, 2024

New changes are detected. LGTM label has been removed.

@astelmashenko
Copy link
Member Author

Please check #545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creydr creydr Awaiting requested review from creydr

@odacremolbap odacremolbap Awaiting requested review from odacremolbap

@aliok aliok Awaiting requested review from aliok

@pierDipi pierDipi Awaiting requested review from pierDipi

Assignees

@dan-j dan-j

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply high CPU issues resolved on 1.10 to main
5 participants
@astelmashenko @dan-j @knative-prow-robot @knative-automation @creydr