Add initial support to produce images in ConfigMap as release artifact #45
Conversation
dsimansk
force-pushed
the
pr/images-in-confgimap
branch
from
89e5d63 to
21c7d26
Compare
|
|
||
| ARTIFACTS_TO_PUBLISH="${CONFIMAP_YAML} ${IMAGES_TXT}" | ||
| sha256sum ${ARTIFACTS_TO_PUBLISH} >checksums.txt | ||
| ARTIFACTS_TO_PUBLISH="${ARTIFACTS_TO_PUBLISH} checksums.txt" |
There was a problem hiding this comment.
checksum.txt is required by release script itself to complete successfully.
| echo "Collect image shas into ConfigMap" | ||
| generate_configMap | ||
|
|
||
| ARTIFACTS_TO_PUBLISH="${CONFIMAP_YAML} ${IMAGES_TXT}" |
There was a problem hiding this comment.
Both files should be added store within the same location as yaml of other components are.
There was a problem hiding this comment.
https://storage.googleapis.com/knative-nightly/eventing-integrations/latest/eventing-integrations-images.yaml
Hopefully, but we need to test it in production. :)
There was a problem hiding this comment.
Perhaps, dropping eventing-integrations from the filename to get rid off duplicated name. WDYT?
There was a problem hiding this comment.
I like eventing-integrations-images.yam
I think that makes sense, when we require it to end up in https://github.com/knative/eventing/tree/main/config/core/configmaps
Or perhaps just integration-images?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold we can always adjust |
Changes
/cc @matzew