url: Work around Clang miscompile on mips64el

klzgrad · Feb 16, 2024 · f5e3686 · f5e3686
1 parent c310f5f
commit f5e3686
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/url/url_canon_ip.cc b/src/url/url_canon_ip.cc
@@ -149,7 +149,10 @@ CanonHostInfo::Family DoIPv4AddressToNumber(const CHAR* spec,
   while (true) {
     // If this is not the first character of a component, go to the next
     // component.
-    if (current_position != host.begin && spec[current_position - 1] != '.') {
+    // XXX: On mips64el, using
+    // `current_position != host.begin && spec[current_position - 1] != '.'`
+    // would have current_position going to the negative.
+    if (current_position > host.begin && spec[current_position - 1] != '.') {
       --current_position;
       continue;
     }