Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start fixing cov for trie #692

Merged
merged 2 commits into from
Feb 7, 2025
Merged

start fixing cov for trie #692

merged 2 commits into from
Feb 7, 2025

Conversation

Eikix
Copy link
Member

@Eikix Eikix commented Feb 6, 2025

closes #678

@Eikix
Copy link
Member Author

Eikix commented Feb 6, 2025

will investigate the rest of the missing lines, it's unclear whether they are not covered or just bugged

image image

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.44%. Comparing base (bee0671) to head (e2868e6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cairo/ethereum/cancun/trie.cairo 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #692   +/-   ##
=======================================
  Coverage   66.44%   66.44%           
=======================================
  Files          88       88           
  Lines       20433    20435    +2     
=======================================
+ Hits        13577    13579    +2     
  Misses       6856     6856           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Eikix Eikix marked this pull request as ready for review February 7, 2025 08:57
@Eikix
Copy link
Member Author

Eikix commented Feb 7, 2025

looks like the coverage report is mostly ";"
i can't find single blocks of code not covered

tbd once we fix coverage report with debug_info

obatirou
obatirou previously approved these changes Feb 7, 2025
@ClementWalter ClementWalter merged commit 1a30066 into main Feb 7, 2025
10 of 11 checks passed
@ClementWalter ClementWalter deleted the cov/trie branch February 7, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cov: trie.cairo
3 participants