-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: improve bitwise tests #73
Test: improve bitwise tests #73
Conversation
You need to format your code, we're using Trunk Otherwise it looks good, just need to rebase with Also, there is a telegram group for the cairo vm ts devs, if you haven't joined yet: https://t.me/cairovmts |
Hey, @zmalatrax I'm having these issues when trying to format the code: |
Hi @danielcdz Take a look at Setting up the environment, from the Cairo docs |
Ty! I'm working on Windows, it was difficult to install the compiler hahaha, but I already made it, but idk if is working well, cause when I try to compile a Cairo file using cairo-compile it doesn't do anything |
Working with Windows usually comes with quite a lot of problems 😅 I'd recommend you to do your dev work on WSL2, quite easy to install and you'll have a linux distro (e.g. ubuntu) 'inside' your windows |
@zmalatrax code should be formated now! A lot of workaround to be able to run cairo-compile hahaha, ty for all the suggestions and patience! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove unused imports.
also you need to sign your commits, follow the github doc. it's a best practice especially when working on oss projects as anyone can otherwise impersonate you
@ClementWalter now my commits are going to be signed! ty for the advice 🫡 |
Summary
cairoRunner.test.ts
file