Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: improve bitwise tests #73

Merged

Conversation

danielcdz
Copy link
Contributor

@danielcdz danielcdz commented May 31, 2024

Summary

@danielcdz danielcdz marked this pull request as ready for review June 1, 2024 15:36
@danielcdz danielcdz requested a review from zmalatrax June 1, 2024 15:36
@danielcdz danielcdz requested a review from zmalatrax June 5, 2024 02:11
@danielcdz danielcdz requested a review from zmalatrax June 6, 2024 12:29
@zmalatrax
Copy link
Collaborator

You need to format your code, we're using Trunk

Otherwise it looks good, just need to rebase with main

Also, there is a telegram group for the cairo vm ts devs, if you haven't joined yet: https://t.me/cairovmts

@danielcdz
Copy link
Contributor Author

Hey, @zmalatrax I'm having these issues when trying to format the code:

image
image
Do you know how to solve them?

@zmalatrax
Copy link
Collaborator

Hi @danielcdz
It looks like you haven't the cairo-format command available in your PATH (as well as the cairo-compile one I think)
You need to install the python Cairo compiler in order to format and compile Cairo Zero programs.

Take a look at Setting up the environment, from the Cairo docs

@danielcdz
Copy link
Contributor Author

Hi @danielcdz It looks like you haven't the cairo-format command available in your PATH (as well as the cairo-compile one I think) You need to install the python Cairo compiler in order to format and compile Cairo Zero programs.

Take a look at Setting up the environment, from the Cairo docs

Ty! I'm working on Windows, it was difficult to install the compiler hahaha, but I already made it, but idk if is working well, cause when I try to compile a Cairo file using cairo-compile it doesn't do anything

@zmalatrax
Copy link
Collaborator

Hi @danielcdz It looks like you haven't the cairo-format command available in your PATH (as well as the cairo-compile one I think) You need to install the python Cairo compiler in order to format and compile Cairo Zero programs.
Take a look at Setting up the environment, from the Cairo docs

Ty! I'm working on Windows, it was difficult to install the compiler hahaha, but I already made it, but idk if is working well, cause when I try to compile a Cairo file using cairo-compile it doesn't do anything

Working with Windows usually comes with quite a lot of problems 😅

I'd recommend you to do your dev work on WSL2, quite easy to install and you'll have a linux distro (e.g. ubuntu) 'inside' your windows

@danielcdz
Copy link
Contributor Author

@zmalatrax code should be formated now! A lot of workaround to be able to run cairo-compile hahaha, ty for all the suggestions and patience!

zmalatrax
zmalatrax previously approved these changes Jun 13, 2024
Copy link
Member

@ClementWalter ClementWalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove unused imports.

also you need to sign your commits, follow the github doc. it's a best practice especially when working on oss projects as anyone can otherwise impersonate you

@danielcdz
Copy link
Contributor Author

@ClementWalter now my commits are going to be signed! ty for the advice 🫡

@danielcdz danielcdz requested a review from zmalatrax June 14, 2024 14:17
@ClementWalter ClementWalter merged commit 56aefcd into kkrt-labs:main Jun 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: make direct use of builtin pointer rather than built-in cairo functions
3 participants