feat: Add proper felt division #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmalatrax
force-pushed
the
feat/felt-division
branch
from
467b7b5 to
d371370
Compare
zmalatrax
force-pushed
the
feat/felt-division
branch
from
d371370 to
cf42ab1
Compare
ClementWalter
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #49
Add Felt division (modular multiplicative inverse) based on the binary exponentiation.
Identified a bug in the test case "should deduce op1 for assert eq res logic add", using the oplogic "op0 * op1" instead of "op0 + op1". It confirms that string types are not suitable to perform this logic and should rather use enum/const objects, which will be addressed in another PR.
Haven't spotted this bug before, as
divwas an integer division3n - 2n == 1nand3n / 2n == 1n, test succeeding in both cases