Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/spring cleaning #36

Merged
merged 4 commits into from
Nov 24, 2023
Merged

Feat/spring cleaning #36

merged 4 commits into from
Nov 24, 2023

Conversation

Eikix
Copy link
Member

@Eikix Eikix commented Nov 24, 2023

  • make memory list of list
  • delete memory manager
  • transform Uint32 into Uint53 -> use Number.MAX_SAFE_INTEGER as a usize high cap

challengeable:

  • bug in fibonacci test: it appears executionEnd is last known AP -> whereas AP points to the latest free cell, so technically, shouldn't last fibonacci be AP.sub(1) -> since it's the latest "taken" memory cell? see per-ultimate commit

greged93
greged93 reviewed Nov 24, 2023
View reviewed changes
src/runners/cairoRunner.test.ts Outdated Show resolved Hide resolved
src/runners/cairoRunner.ts Outdated Show resolved Hide resolved
greged93
greged93 approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@greged93 greged93 merged commit 38c3b1c into kkrt-labs:main Nov 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greged93 greged93 greged93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eikix @greged93