Initial Version #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
benoit74
requested changes
Jan 27, 2025
There was a problem hiding this comment.
Very good work obviously.
Of course I have found lot's of things to comment, but nothing very big.
I think the program overall misses few safeguards:
- avoid silly (small) settings of sleep period (e.g. never smaller than 5 mins) to avoid flooding our servers
- avoid removing too many ZIMs at once => this is a bit blurry, but the scenario I have in mind is that should we publish an empty catalog for any reason (or should the program believe the catalog is empty for any reason), it would be a pity / concern to cause all ZIMs of all peers to be deleted within few hours ; maybe even deleting too many ZIMs at once is an indicator of an issue ; that been said, since we keep the ZIMs for
--keepdays, the impact is obviously not immediate ... should we simply have an alerting system? a summary file one can watch with details about files which are going to be removed in 1 week, 2 weeks, 4 weeks, 8 weeks, 12 weeks?
- Basic functionnality present - Works both standalone and all-in-one Docker image
- added Title and Description filters. - Removed nodet flavour choice (now gone) - All matches now case insensitive - Default sleep interval to 1d for docker script
rgaudin
force-pushed
the
initial_version
branch
from
a7b84e6 to
91973f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@benoit74 that's basically a transfer of what was on kci and running on kathrin.
Please raise your questions and I'll document whatever needs to be.