Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ButtonLink design #610

Merged
merged 6 commits into from
Jun 27, 2023
Merged

Update ButtonLink design #610

merged 6 commits into from
Jun 27, 2023

Conversation

PavelHolec
Copy link
Collaborator

@PavelHolec PavelHolec commented Jun 26, 2023

Also partially implements #605 by application on Button and SocialButton

Screen.Recording.2023-06-26.at.17.40.32.mov
Screen.Recording.2023-06-26.at.16.46.03.mov
Screen.Recording.2023-06-26.at.14.56.18.mov

@PavelHolec PavelHolec added the enhancement New feature or request label Jun 26, 2023
@PavelHolec PavelHolec added this to the 2023Q2 milestone Jun 26, 2023
@PavelHolec PavelHolec requested a review from sjavora June 26, 2023 15:48
@PavelHolec PavelHolec requested a review from a team as a code owner June 26, 2023 15:48
@PavelHolec PavelHolec self-assigned this Jun 26, 2023
@PavelHolec PavelHolec linked an issue Jun 26, 2023 that may be closed by this pull request
@PavelHolec PavelHolec changed the title Update ButtonLink design Update ButtonLink design Jun 26, 2023
@PavelHolec PavelHolec requested a review from hrach June 26, 2023 15:49
@PavelHolec PavelHolec force-pushed the 532-update-buttonlink-design branch from 37c284f to d0b47d9 Compare June 26, 2023 15:52
@sjavora
Copy link
Member

sjavora commented Jun 26, 2023

I assume the changes in alignment of titles/icons in buttons are intentional?

@PavelHolec PavelHolec force-pushed the 532-update-buttonlink-design branch from fbfd4ca to f84602f Compare June 27, 2023 07:51
@PavelHolec
Copy link
Collaborator Author

I assume the changes in alignment of titles/icons in buttons are intentional?

Those for Button and SocialButton weren't - should be fixed now.

@PavelHolec PavelHolec force-pushed the 532-update-buttonlink-design branch from 60ff073 to e5d54c5 Compare June 27, 2023 08:23
@sjavora
Copy link
Member

sjavora commented Jun 27, 2023

buttonSize could be replaced with the native controlSize for iOS 15+.

@PavelHolec PavelHolec merged commit 3ed0ab3 into main Jun 27, 2023
@PavelHolec PavelHolec deleted the 532-update-buttonlink-design branch June 27, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ButtonLink design
2 participants