Change min to stdmin #363
Open
Change min to stdmin #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
min and max macros are also defined and used in the esp8266_webinterface example sketch. Yes, max was defined in two source files. Some of the code has gotten a bit sloppy over the years. :) If you could fix those as well, that would help. My github merge mojo is dreadful, so it would be helpful if all the related code changes were all in one place. |
|
Ok, done. That said, I didn't give it a test because I don't have a board to test with. I see no reason why it won't work, but those are famous last words... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put in requested fix to change min to std::min