Change max to stdmax #362
Open
Change max to stdmax #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind doing the same for the min macro? |
|
Happy to help. Just scanned the code for min and the only usage is in WS2812FX.cpp. In my system, that seems to be pulled from template in a esp32 include file and compiling fine. It probably makes sense to switch to std::min, but wanted to put this info out there. I will make the change, test it, and create another PR for you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ok, i changed the 'new' macro fix (ws2812fx_max) to the recommended std::max from algorithm.h. This works fine on my complex program so far.