Fully migrate to pyproject.toml #500
Conversation
Split from kislyuk#474
| setup( | ||
| url="https://github.com/kislyuk/argcomplete", | ||
| packages=find_packages(exclude=["test", "test.*"]), | ||
| package_data={"argcomplete": ["bash_completion.d/_python-argcomplete", "py.typed"]}, |
There was a problem hiding this comment.
It looks like package_data is not migrated
There was a problem hiding this comment.
You don't need it due to setuptools_scm AFAIK.
There was a problem hiding this comment.
That doesn't make any sense. setuptools_scm manages the version, package_data manages including non-Python files in the distribution.
There was a problem hiding this comment.
It also includes a hook for include_package_data, which is enabled by default in pyproject.toml projects, which includes all files tracked by Git unless otherwise excluded.
There was a problem hiding this comment.
@kislyuk So would you rather not rely on setuptools_scm and would like me to add an explicit tool.setuptools.package-data and/or possibly disable or explicitly enable include-package-data (It defaults to enable in pyproject.toml projects AFAIK)?
You can see the docs about this here https://setuptools.pypa.io/en/latest/userguide/datafiles.html#data-files-support
|
Thanks for your contribution. I ended up doing equivalent changes as part of migrating the build system from setuptools to hatch (as is now recommended by the Python publishing guide). |
Split from #474