Merge pull request #116 from kingstinct/revert-113-fix/infinite_updat…

…e_useStatisticsForQuantity

.github/workflows/test.yml

@@ -5,7 +5,7 @@ name: Test
 # Controls when the action will run.
 on:
   push:
-    branches: [ "**" ]
+  pull_request:
   workflow_dispatch:
 
 # A workflow run is made up of one or more jobs that can run sequentially or in parallel

README.md

@@ -91,13 +91,26 @@ Some imperative examples:
   console.log(quantity) // 17.5
   console.log(unit) // %
 
-  /* Listen to data */
   await HealthKit.requestAuthorization([HKQuantityTypeIdentifier.heartRate]); // request read permission for heart rate
 
-  /* Make sure to request permissions before subscribing to changes */
-  const unsubscribe = HealthKit.subscribeToChanges(HKQuantityTypeIdentifier.heartRate, () => {
-    // refetch whichever queries you need
-  });
+  /* Subscribe to data (Make sure to request permissions before subscribing to changes) */
+  const [hasRequestedAuthorization, setHasRequestedAuthorization] = useState(false);
+
+  useEffect(() => {
+    HealthKit.requestAuthorization([HKQuantityTypeIdentifier.heartRate]).then(() => {
+      setHasRequestedAuthorization(true);
+    });
+  }, []);
+
+  useEffect(() => {
+    if (hasRequestedAuthorization) {
+      const unsubscribe = HealthKit.subscribeToChanges(HKQuantityTypeIdentifier.heartRate, () => {
+        // refetch data as needed
+      });
+    }
+
+    return () => unsubscribe();
+  }, [hasRequestedAuthorization]);
 
   /* write data */
   await HealthKit.requestAuthorization([], [HKQuantityTypeIdentifier.insulinDelivery]); // request write permission for insulin delivery

src/hooks/useStatisticsForQuantity.ts

@@ -32,7 +32,7 @@ function useStatisticsForQuantity<TIdentifier extends HKQuantityTypeIdentifier,
 
   useEffect(() => {
     void update()
-  }, [])
+  }, [update])
 
   useSubscribeToChanges(identifier, update)
 

src/native-types.ts

@@ -1548,7 +1548,7 @@ export enum HKUnits {
   Percent = '%',
   Count = 'count',
   InternationalUnit = 'IU',
-  AppleEffortScore = "appleEffortScore"
+  AppleEffortScore = 'appleEffortScore'
 }
 
 export type MeterUnit<Prefix extends HKMetricPrefix = HKMetricPrefix.None> =