refactor(#1137): separate deleteLineFromPath function from the logic …

…of the settings-routes
kimbu-chat · Sep 10, 2022 · e258d2c · e258d2c
1 parent 72f4869
commit e258d2c
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 9 deletions.
diff --git a/src/routing/routes/main-routes.ts b/src/routing/routes/main-routes.ts
@@ -36,9 +36,9 @@ const MainRoutes: MainRoutesObject = {
     props: {
       element: withPageGuard([REGISTERED_USER])(ChatPage),
       children: [
-        React.createElement(Route, { key: 1, index: true, element: React.createElement(Welcome) }),
-        React.createElement(Route, { key: 2, path: ':id', element: React.createElement(MessageList) }),
-        React.createElement(Route, { key: 3, path: '*', element: React.createElement(Welcome) }),
+        React.createElement(Route, { key: '1', index: true, element: React.createElement(Welcome) }),
+        React.createElement(Route, { key: '2', path: ':id', element: React.createElement(MessageList) }),
+        React.createElement(Route, { key: '3', path: '*', element: React.createElement(Welcome) }),
       ],
     },
   },

diff --git a/src/routing/routes/settings-routes.ts b/src/routing/routes/settings-routes.ts
@@ -17,6 +17,9 @@ import {
 import { SettingsRoutesEnum, SettingsRoutesObject } from '@routing/routing.types';
 import withPageGuard from '@routing/with-page-guard';
 
+import { deleteLineFromPath } from './utils';
+
+/* ------------- LazyLoading ------------- */
 const ProfileSettings = LazyPreload(() => import('@pages/settings/edit-profile'));
 const NotificationsSettings = LazyPreload(() => import('@pages/settings/notifications-settings'));
 const LanguageSettings = LazyPreload(() => import('@pages/settings/language-settings'));
@@ -25,12 +28,6 @@ const AppearanceSettings = LazyPreload(() => import('@pages/settings/appearance'
 const PrivacySecuritySettings = LazyPreload(() => import('@pages/settings/privacy-security'));
 const AudioVideoSettings = LazyPreload(() => import('@pages/settings/audio-video'));
 
-const deleteLineFromPath = (path: string, line: string) => {
-  const preparedPath = path.split('');
-  preparedPath.splice(path.indexOf(line), line.length);
-  return preparedPath.join('');
-};
-
 /* ------------- Routes ------------- */
 const SettingsRoutes: SettingsRoutesObject = {
   [SettingsRoutesEnum.PROFILE_SETTINGS]: {

diff --git a/src/routing/routes/utils.ts b/src/routing/routes/utils.ts
@@ -0,0 +1,5 @@
+export const deleteLineFromPath = (path: string, line: string) => {
+  const preparedPath = path.split('');
+  preparedPath.splice(path.indexOf(line), line.length);
+  return preparedPath.join('');
+};