Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused or obsolete methods from Iterables2 #208

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

HannesWell
Copy link
Contributor

This change is based on the assumption that the class Iterables2 is considered an internal helper and not a user facing API.

If that assumption is wrong, this change would indeed breaking change for users.

Copy link
Member

@NiklasRentzCAU NiklasRentzCAU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good simplification, especially using the reduce function instead of implementing it with this fold function. However, I cannot really test this change, because I have never used these exportBrandings or even really know how they were used. Do you have some test for this change that you could provide as well?

@HannesWell
Copy link
Contributor Author

This looks like a good simplification, especially using the reduce function instead of implementing it with this fold function. However, I cannot really test this change, because I have never used these exportBrandings or even really know how they were used. Do you have some test for this change that you could provide as well?

I just modified our Eclipse product product a bit so that they are used and after fixing a few bugs (see #210 :) ), it worked perfectly fine.
So I can confirm it works as expected, but I cannot provide a standalone test case for it. I hope that's sufficient.

@NiklasRentzCAU NiklasRentzCAU merged commit 6ccc10d into kieler:master Oct 21, 2024
2 checks passed
@HannesWell HannesWell deleted the cleanup-Iterables2 branch October 21, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants