Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added previously reexported dependencies explicitly. #205

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

soerendomroes
Copy link
Member

To be merged once eclipse-elk/elk#1074 is released.

@HannesWell
Copy link
Contributor

Thank you for this one. I wanted to propose a similar change with the same resulting changes.

This could be submitted even before eclipse-elk/elk#1074, having more dependencies than (currently) absolutely necessary should not cause any harm.

@NiklasRentzCAU NiklasRentzCAU marked this pull request as ready for review October 21, 2024 11:31
Copy link
Member

@NiklasRentzCAU NiklasRentzCAU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NiklasRentzCAU NiklasRentzCAU merged commit f8ce58e into master Oct 21, 2024
2 of 3 checks passed
@NiklasRentzCAU NiklasRentzCAU deleted the sdo/fixRemovedElkReexportDependencies branch October 21, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants