Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRVLOGIC-202: Schedule apache-main sync from upstream #8

Conversation

fantonangeli
Copy link

Jira: https://issues.redhat.com/browse/SRVLOGIC-202

Description:
Set up a GitHub Action to sync our midstream main-apache branch with the upstream main branch every day.

Please note:
If approved I will change the default branch to main to let the CI run as scheduled.

Repository used for tests:
https://github.com/fantonangeli/incubator-kie-kogito-images-fantonangeli-test

@ricardozanini
Copy link
Member

@fantonangeli @rgdoliveira I think we have a problem with the bats tests. Maybe we should investigate more to avoid merging red PRs.

@rgdoliveira
Copy link
Member

@fantonangeli @rgdoliveira I think we have a problem with the bats tests. Maybe we should investigate more to avoid merging red PRs.

@ricardozanini I took a quickly look and it seems it is also failing in Apache upstream PRs with the same error, see apache#1734 as an example.

IIUC, this test clones https://github.com/bats-core/bats-core.git (master branch?) which may have changed something in the behavior and now the test is failing.

@rgdoliveira
Copy link
Member

@ricardozanini it seems I fixed it upstream with PR apache#1738, after it is merged upstream I can sync midstream with upstream.

@rgdoliveira
Copy link
Member

@ricardozanini @fantonangeli please review #10 and after it is merged @fantonangeli can rebase this PR, so hopefully the basts test will be green.

@rgdoliveira
Copy link
Member

@fantonangeli PR is merged, please rebase your branch in main branch and the bats test should be green.

@rgdoliveira rgdoliveira merged commit 05117b7 into kiegroup:main Jan 29, 2024
4 checks passed
@rgdoliveira
Copy link
Member

merged, thanks @fantonangeli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants