forked from apache/incubator-kie-kogito-images
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recreate imagestream.yaml removed from upstream and add PR check for it #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New name is openshift-serverless-logic-imagestream.yaml to avoid issues when syncing with upstream main branch
…verless-logic-imagestream.yaml
rgdoliveira
requested review from
mareknovotny,
ricardozanini and
fantonangeli
January 25, 2024 13:04
mareknovotny
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use this opportunity to remove Kogito naming from our bits!
Co-authored-by: Ricardo Zanini <[email protected]>
@ricardozanini thanks, I've applied your suggestions |
ricardozanini
approved these changes
Jan 26, 2024
@rgdoliveira mind taking a look at the bats test that's failing? |
Let's discuss it on the other PR (from Fabrizio) and merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
Please make sure your PR meets the following requirements:
[KOGITO|RHPAM-XYZ] Subject
How to retest this PR or trigger a specific build:
(Re)run Jenkins tests
Please add comment: Jenkins [test|retest] this
Prod tests
Please add comment: Jenkins (re)run [prod|Prod|PROD]
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.