[JBPM-10242] Allow the possibility of disabling linear search for removeJob and getTimerByName operations #2441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins do fdb |
|
jenkins do fdb |
fjtirado
commented
Sep 20, 2024
...ejb/jbpm-services-ejb-timer/src/main/java/org/jbpm/services/ejb/timer/EJBTimerScheduler.java
Outdated
Show resolved
Hide resolved
|
jenkins run fdb |
fjtirado
force-pushed
the
timer_cancel_path
branch
from
c44c057
to
d79847f
Compare
Unless explicilty stated with property org.jbpm.ejb.timer.linear.search
|
jenkins run fdb |
1 similar comment
|
jenkins run fdb |
fjtirado
changed the title
|
jenkins run fdb |
fjtirado
force-pushed
the
timer_cancel_path
branch
4 times, most recently
from
77f5bdd
to
ee5587e
Compare
fjtirado
force-pushed
the
timer_cancel_path
branch
4 times, most recently
from
88b0b04
to
509e6cf
Compare
Setting org.jbpm.ejb.timer.disable.linear.search and org.jbpm.ejb.timer.disable.linear.remove to true
fjtirado
force-pushed
the
timer_cancel_path
branch
from
509e6cf
to
22f29fc
Compare
|
jenkins do fdb |
fjtirado
force-pushed
the
timer_cancel_path
branch
from
904558e
to
5fad599
Compare
fjtirado
force-pushed
the
timer_cancel_path
branch
from
5fad599
to
7007fdb
Compare
|
jenkins do fdb |
|
thanks @gmunozfe |
fjtirado
added
backport-7.67.x
github-actions bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
…oveJob and getTimerByName operations (#2441) * Try to cancel timer always, and only search if timer cancellation fails * Skipping list search completely if !searchIfFailed * [JBPM-10242] Always skipping linear search Unless explicilty stated with property org.jbpm.ejb.timer.linear.search * [JBPM-10242] Disable linear search on condition Setting org.jbpm.ejb.timer.disable.linear.search and org.jbpm.ejb.timer.disable.linear.remove to true * [JBPM-10242] Fixing integration tests --------- Co-authored-by: krisv <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
…oveJob and getTimerByName operations (#2441) * Try to cancel timer always, and only search if timer cancellation fails * Skipping list search completely if !searchIfFailed * [JBPM-10242] Always skipping linear search Unless explicilty stated with property org.jbpm.ejb.timer.linear.search * [JBPM-10242] Disable linear search on condition Setting org.jbpm.ejb.timer.disable.linear.search and org.jbpm.ejb.timer.disable.linear.remove to true * [JBPM-10242] Fixing integration tests --------- Co-authored-by: krisv <[email protected]>
|
There are compiler errors in backported PRs, are we missing some other commits there? Please check this @fjtirado @gmunozfe |
gmunozfe
pushed a commit
to gmunozfe/jbpm
that referenced
this pull request
Oct 9, 2024
…oveJob and getTimerByName operations (kiegroup#2441) * Try to cancel timer always, and only search if timer cancellation fails * Skipping list search completely if !searchIfFailed * [JBPM-10242] Always skipping linear search Unless explicilty stated with property org.jbpm.ejb.timer.linear.search * [JBPM-10242] Disable linear search on condition Setting org.jbpm.ejb.timer.disable.linear.search and org.jbpm.ejb.timer.disable.linear.remove to true * [JBPM-10242] Fixing integration tests --------- Co-authored-by: krisv <[email protected]>
gmunozfe
pushed a commit
to gmunozfe/jbpm
that referenced
this pull request
Oct 9, 2024
…oveJob and getTimerByName operations (kiegroup#2441) * Try to cancel timer always, and only search if timer cancellation fails * Skipping list search completely if !searchIfFailed * [JBPM-10242] Always skipping linear search Unless explicilty stated with property org.jbpm.ejb.timer.linear.search * [JBPM-10242] Disable linear search on condition Setting org.jbpm.ejb.timer.disable.linear.search and org.jbpm.ejb.timer.disable.linear.remove to true * [JBPM-10242] Fixing integration tests --------- Co-authored-by: krisv <[email protected]>
This was referenced Oct 9, 2024
gmunozfe
pushed a commit
to gmunozfe/jbpm
that referenced
this pull request
Oct 9, 2024
…oveJob and getTimerByName operations (kiegroup#2441) * Try to cancel timer always, and only search if timer cancellation fails * Skipping list search completely if !searchIfFailed * [JBPM-10242] Always skipping linear search Unless explicilty stated with property org.jbpm.ejb.timer.linear.search * [JBPM-10242] Disable linear search on condition Setting org.jbpm.ejb.timer.disable.linear.search and org.jbpm.ejb.timer.disable.linear.remove to true * [JBPM-10242] Fixing integration tests --------- Co-authored-by: krisv <[email protected]>
gmunozfe
pushed a commit
to gmunozfe/jbpm
that referenced
this pull request
Oct 10, 2024
…oveJob and getTimerByName operations (kiegroup#2441) * Try to cancel timer always, and only search if timer cancellation fails * Skipping list search completely if !searchIfFailed * [JBPM-10242] Always skipping linear search Unless explicilty stated with property org.jbpm.ejb.timer.linear.search * [JBPM-10242] Disable linear search on condition Setting org.jbpm.ejb.timer.disable.linear.search and org.jbpm.ejb.timer.disable.linear.remove to true * [JBPM-10242] Fixing integration tests --------- Co-authored-by: krisv <[email protected]>
gmunozfe
pushed a commit
to gmunozfe/jbpm
that referenced
this pull request
Oct 10, 2024
…oveJob and getTimerByName operations (kiegroup#2441) * Try to cancel timer always, and only search if timer cancellation fails * Skipping list search completely if !searchIfFailed * [JBPM-10242] Always skipping linear search Unless explicilty stated with property org.jbpm.ejb.timer.linear.search * [JBPM-10242] Disable linear search on condition Setting org.jbpm.ejb.timer.disable.linear.search and org.jbpm.ejb.timer.disable.linear.remove to true * [JBPM-10242] Fixing integration tests --------- Co-authored-by: krisv <[email protected]>
fjtirado
added a commit
that referenced
this pull request
Oct 10, 2024
…oveJob and getTimerByName operations (#2441) (#2444) * Try to cancel timer always, and only search if timer cancellation fails * Skipping list search completely if !searchIfFailed * [JBPM-10242] Always skipping linear search Unless explicilty stated with property org.jbpm.ejb.timer.linear.search * [JBPM-10242] Disable linear search on condition Setting org.jbpm.ejb.timer.disable.linear.search and org.jbpm.ejb.timer.disable.linear.remove to true * [JBPM-10242] Fixing integration tests --------- Co-authored-by: Francisco Javier Tirado Sarti <[email protected]> Co-authored-by: krisv <[email protected]>
fjtirado
added a commit
that referenced
this pull request
Oct 10, 2024
…earch for rem… (#2446) * Revert "RHPAM-4779: SLA due date value in ProcessInstanceLog table is not upd… (#2396) (#2436)" This reverts commit 2d8b32b. * [JBPM-10242] Allow the possibility of disabling linear search for removeJob and getTimerByName operations (#2441) * Try to cancel timer always, and only search if timer cancellation fails * Skipping list search completely if !searchIfFailed * [JBPM-10242] Always skipping linear search Unless explicilty stated with property org.jbpm.ejb.timer.linear.search * [JBPM-10242] Disable linear search on condition Setting org.jbpm.ejb.timer.disable.linear.search and org.jbpm.ejb.timer.disable.linear.remove to true * [JBPM-10242] Fixing integration tests --------- Co-authored-by: krisv <[email protected]> --------- Co-authored-by: Francisco Javier Tirado Sarti <[email protected]> Co-authored-by: krisv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://issues.redhat.com/browse/JBPM-10242