Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove node 14 #423

Closed
wants to merge 1 commit into from
Closed

Conversation

shubhbapna
Copy link
Contributor

@shubhbapna shubhbapna commented Apr 14, 2023

Part fix for #405

We don't have to release a new version since we were anyways building it in node 16

MERGE AFTER:

@Ginxo
Copy link
Contributor

Ginxo commented Apr 17, 2023

but the tool still working with 14.x, why do we need to make it more restrictive? I mean I understand node14 is going EOL but it does not mean the tool is not compatible with 14.x, right?

@shubhbapna
Copy link
Contributor Author

shubhbapna commented Apr 17, 2023

Right but we will have to start supporting node 18 which might have some breaking changes for node 14 right? (we faced this when we were supporting node 12, 14, and 16 and had to drop 12 because some features like optional chaining in node 16 didn't work with node 12).

For any new feature won't it be enough to make sure that it works in the currently maintained and stable node versions and not the EOL ones?

@Ginxo

@shubhbapna
Copy link
Contributor Author

@Ginxo soon the packages that we depend on will also drop support for node 14, 16:

And certain packages like gitlab sdk are only supporting node 18 or up now:

@Ginxo
Copy link
Contributor

Ginxo commented May 16, 2023

ok, please resolve lock conflicts and we will merge. Thanks mate

@shubhbapna shubhbapna closed this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants