coins22: 基礎科目(選択)が上限を超えて全体の単位数に加算されないようにする #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unsigned-wrong-wrong-int
changed the title
|
とても良い提案をありがとうございます |
puripuri2100
added a commit
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
現在の実装では，基礎共通選択1～5単位および基礎関連選択6～10単位の制約と，全体の単位数の計算とが別々に行われています．そのため，例えば基礎共通選択を6単位，基礎関連選択を10単位取ると全体の単位数に16単位含まれてしまいます．履修要覧の卒業要件の表を見ると，基礎共通選択と基礎関連選択の合計は11単位を超えないようにする必要がありそうです．
このPRでは，
CreditsDataを入れ子にして，超過分を全体の単位数に算入しないように変更します．