Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass CI tests on main #465

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Pass CI tests on main #465

merged 1 commit into from
Jan 29, 2025

Conversation

Dhananjhay
Copy link
Contributor

Proposed changes

Describe the changes implemented in this pull request. If the changes fix a bug or resolves a feature request, be sure to link the issue (and explain how the changes address the issue). Be sure to select a label describing the PR (e.g. maintenance).

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

Notes

All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

Copy link
Member

@akhanf akhanf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Dhananjhay
Copy link
Contributor Author

Dhananjhay commented Jan 28, 2025

All 37 unit tests passed! Ready to merge @akhanf.

@akhanf
Copy link
Member

akhanf commented Jan 28, 2025

Is that commit message correct? I didn't think bids specs are being updated here..

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.37%. Comparing base (ffb7752) to head (ff5bbc9).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #465   +/-   ##
=======================================
  Coverage   94.37%   94.37%           
=======================================
  Files          55       55           
  Lines        2222     2223    +1     
=======================================
+ Hits         2097     2098    +1     
  Misses        125      125           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dhananjhay
Copy link
Contributor Author

Dhananjhay commented Jan 29, 2025

Yes. I was hesitant with the commit message too but the error on main branch said bids specs out of date, run poetry run poe update-bids but I've fixed the message now; it was merely a syntax issue.

@Dhananjhay Dhananjhay merged commit 303bd31 into khanlab:main Jan 29, 2025
39 checks passed
@pvandyken pvandyken added the maintenance Updates or improvements that do not change functionality of the code label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Updates or improvements that do not change functionality of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants