Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm support for Python 3.13 and drop 3.8 #143

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

khaeru
Copy link
Owner

@khaeru khaeru commented Sep 25, 2024

Python 3.13 will be released 2024-10-01 2024-10-07. This PR is to:

PR checklist

  • Checks all ✅
  • Update documentation N/A
  • Update doc/whatsnew.rst

@khaeru khaeru self-assigned this Sep 25, 2024
@khaeru khaeru added the enh New feature or request label Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.85%. Comparing base (18d3ec2) to head (c3178dc).

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #143      +/-   ##
===========================================
- Coverage   100.00%   99.85%   -0.15%     
===========================================
  Files           51       51              
  Lines         4695     4688       -7     
===========================================
- Hits          4695     4681      -14     
- Misses           0        7       +7     
Files with missing lines Coverage Δ
genno/caching.py 100.00% <100.00%> (ø)
genno/compat/graphviz.py 100.00% <100.00%> (ø)
genno/compat/pint.py 100.00% <100.00%> (ø)
genno/compat/plotnine/plot.py 100.00% <100.00%> (ø)
genno/compat/pyam/__init__.py 100.00% <100.00%> (ø)
genno/compat/sdmx/operator.py 100.00% <100.00%> (ø)
genno/compat/sdmx/util.py 100.00% <100.00%> (ø)
genno/compat/xarray.py 100.00% <ø> (ø)
genno/config.py 100.00% <100.00%> (ø)
genno/core/attrseries.py 98.37% <100.00%> (-1.63%) ⬇️
... and 12 more

... and 1 file with indirect coverage changes

khaeru added a commit that referenced this pull request Oct 14, 2024
khaeru added a commit that referenced this pull request Oct 14, 2024
@khaeru
Copy link
Owner Author

khaeru commented Oct 14, 2024

@glatterf42 FYI, I am realising here that the hold-up pending pyarrow 18.0.0 is due to #135 / #128.

That change brought performance improvements, but introduced a fixed dependency on pandas[parquet] instead of merely pandas:
https://github.com/khaeru/genno/blame/18d3ec2c1e2929e4c1b7208ae7d17292680b6cba/pyproject.toml#L31

This in turn is blocking ixmp, message_ix, et al. and as you note there is no promised date for a release of pyarrow 18.0.0.

Because genno releases are easy to put out, I think I will temporarily make this:

  "pandas >= 1.0",
  "pandas[parquet] >= 1.0; python_version < '3.13'",

Thus on Python 3.13, parquet/pyarrow will not be installed, and caching should fall back to less-performant pickle from the standard library.

Once pyarrow 18.0.0 is out, I can make a point release of genno to revert the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enh New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant