Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change strict mode. #3

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Change strict mode. #3

merged 1 commit into from
Oct 12, 2024

Conversation

kfly8
Copy link
Owner

@kfly8 kfly8 commented Oct 12, 2024

This pull request aims to reduce dependencies and simply this module.

  • Remove Devel::Strict
  • Instead use $ENV{PERL_ASSERT_ENABLED}
  • And change strict mode default. Default is enabled.

Reference implement: https://metacpan.org/release/PEVANS/Syntax-Keyword-Assert-0.01/source/lib/Syntax/Keyword/Assert.xs#L167

- Remove Devel::Strict
- Instead use $ENV{PERL_ASSERT_ENABLE}
- And change strict mode default. Default is enabled.

This commit aims to reduce dependencies and simply this module.
@kfly8 kfly8 self-assigned this Oct 12, 2024
@kfly8 kfly8 merged commit e9f9e90 into main Oct 12, 2024
26 checks passed
@kfly8 kfly8 deleted the strict-mode branch October 12, 2024 14:04
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11306234016

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 10538819755: 0.0%
Covered Lines: 37
Relevant Lines: 37

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants