Keep original file extension when rotation occurs (e.g. .error files) #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle file extension properly : if the extension is not .log, use the same extension for rotated files (e.g. if you rotate .error file, it will keep the .error extension).
|
I'm using logrotate to rotate .log and .err files ; keeping the file extension unchanged when rotation occurs is a must-have for our team. E. |
e-dot
changed the title
|
any reason this either wasn't pulled in or has regressed back out of the code? the current install i have has been bulldozing my .err files by renaming them .log, which is usually then overwritten by the stdout .log file that follows. i dropped this diff in manually and it seemed to fix things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle file extension properly : if the extension is not .log, use the same extension for rotated files (e.g. if you rotate .error file, it will keep the .error extension).