fix: Use s.keyman.localhost #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
mcdurdin
reviewed
Dec 1, 2023
There was a problem hiding this comment.
I think LGTM. Can we rely on having website-local-proxy always running and use the same pattern for all the host.docker.internal references? That would avoid a lot of the confusion!
One challenge -- if we run the website-local-proxy on a port other than 80/443
|
I copied your suggestion into #6 to minimize changes here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one might warrant more investigation
afaict, the JS calls in keymanweb.com couldn't get assets from host.docker.internal, while s.keyman.com.localhost worked.