epic: kmc-kmw KeymanWeb compiler in Typescript 🗜 #8954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
developer/
developer/compilers/
feat
epic
keymanapp-test-bot
bot
added
the
user-test-missing
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
…ling-and-more chore(common): cleanup error handling for KmxFileReader and CompilerOptions as shared type
mcdurdin
changed the title
mcdurdin
changed the title
Part 1 of the `CompilerOptions` reorg. kmc now uses `CompilerOptions` throughout, and `CompilerBaseOptions` maps to the set of options available to all activities.
LdmlCompilerOptions is now based on the shared CompilerOptions. Also fixes command line parameter inheritance for sub-commands.
This module is used for identification of Keyman source and binary file formats by file extension. It is not yet appropriate to use for constants; this will come in a future commit.
Now that we have the file type detection in place, we can replace existing references to the file extensions, where possible, with the constant declarations. While we could rely on TypeScript's typing to use string-based values, this helps us to avoid using file extensions directly in string transforms, regex, etc, and use the `KeymanFileTypes` alias instead. Note that only references in common/web, and kmc-* projects have been touched. References in other Developer projects have not been touched, as some of those are not yet ESM, so that needs to be addressed first.
feat(developer): kmc analyze osk-char-use 🗜
…-kmc-kmw chore(developer): enable eslint for kmc-kmw 🗜
…iler-options chore(developer): refactor CompilerOptions 🗜
chore: add run-name to deb-packaging 🗜
chore(developer): minor patches to fix compile issues 🗜
Ensures that we calculate the file type instead of using stored data, which is a lot cleaner. Means we ignore the filetype field in the .kpj xml, which is fine. We should do the same with filename vs filepath.
Turns KeymanDeveloperProjectFile into an interface, and removes redundant data in filename and fileType fields, calculating these from filePath instead. Maintains separate KeymanDeveloperProjectFile10 and KeymanDeveloperProjectFile20 classes implementing the base interface for now, although that may be a target for future consolidation (lowpri).
Projects can contain any type of file, but the fromFilename file type utility function would only handle known source and binary file types.
…ype-references chore(developer): refactor KeymanDeveloperProjectFile 🗜
…oject-file chore(developer): add Error_NotAProjectFile 🗜
…ature-kmc-kmw-a17s18
…re-kmc-kmw-a17s18 chore: merge master into feature-kmc-kmw (A17S18) 🗜
keymanapp-test-bot
bot
removed
the
user-test-missing
mcdurdin
requested review from
rc-swag,
ermshiperete,
jahorton and
darcywong00
as code owners
jahorton
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
If we're going to merge this now, might want to move the last three description-list items into the third one, since its name signifies that the latter is pretty much a catch-all for post-merge stuff.
Builds are all passing, and it doesn't have a net effect on existing products quite yet. We will want testing whenever the new, TS-based tooling is integrated into Developer... but that's not quite here yet.
But, in the meantime, RSLGTM.
|
Changes in this pull request will be available for download in Keyman version 17.0.156-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@keymanapp-test-bot skip