Feature/423 add hardcoded attribute mapper #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes in the PR are finished and is ready to be merged, we are actively utilizing the newly introduced feature. |
|
Would love to see this merged and released. I just ran into a configuration change where these mappers are needed. Anything I can do to assist? |
|
+1, I'm also interested in this feature. |
|
+1, I'm also interested in this feature. |
|
+1 |
|
@angeloxx Are you still interested in landing this? There are some failures because of the move to the new organization and also you need to sign off your commit (see https://git-scm.com/docs/git-commit#Documentation/git-commit.txt--s). |
Signed-off-by: angeloxx <[email protected]>
Signed-off-by: angeloxx <[email protected]>
Signed-off-by: angeloxx <[email protected]>
Signed-off-by: angeloxx <[email protected]>
angeloxx
force-pushed
the
feature/423-add-hardcoded-attribute-mapper
branch
2 times, most recently
from
39e6489 to
7b6ea74
Compare
Signed-off-by: angeloxx <[email protected]>
|
All checks passed, I updated the PR with the new org and signed off all the commits. Thanks for your time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will include the hardcoded-attribute-mapper (not the hardcoded-ldap-attribute-mapper, still requested in #423)