Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow definition of multivalued user profile attributes #1071

Merged

Conversation

thomasdarimont
Copy link
Contributor

In order to replicate the existing userprofile configuration, we need to support the multivalued attribute.

We now support the multi_valued = bool attribute.

Example:

  attribute {
    name = "myAttr"

    multi_valued = true

    validator {
      name = "options"
      config = {
        options = jsonencode(["opt1", "opt2", "opt3"])
      }
    }

    annotations = {
      foo = jsonencode({ "key" : "val" })
    }
  }

Fixes #1064

@thomasdarimont thomasdarimont force-pushed the issue/gh-1064-user-profile-multivalued branch 5 times, most recently from 40220c7 to 1457f2c Compare January 13, 2025 22:09
@thomasdarimont thomasdarimont marked this pull request as draft January 13, 2025 22:39
@thomasdarimont thomasdarimont force-pushed the issue/gh-1064-user-profile-multivalued branch from 1457f2c to 3ba9456 Compare January 13, 2025 22:53
@thomasdarimont thomasdarimont marked this pull request as ready for review January 13, 2025 23:22
In order to replicate the existing userprofile configuration, we need to support the multivalued attribute.

We now support the `multi_valued = bool` attribute.

Example:
```hcl
  attribute {
    name = "myAttr"

    multi_valued = true

    validator {
      name = "options"
      config = {
        options = jsonencode(["opt1", "opt2", "opt3"])
      }
    }

    annotations = {
      foo = jsonencode({ "key" : "val" })
    }
  }
 ```

 Fixes keycloak#1064

Signed-off-by: Thomas Darimont <[email protected]>
@thomasdarimont thomasdarimont force-pushed the issue/gh-1064-user-profile-multivalued branch from 3ba9456 to e7977e8 Compare January 13, 2025 23:24
Copy link
Contributor

@sschu sschu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sschu sschu merged commit 9ddb9fc into keycloak:main Jan 14, 2025
9 checks passed
angeloxx pushed a commit to angeloxx/terraform-provider-keycloak that referenced this pull request Jan 26, 2025
…k#1071)

In order to replicate the existing userprofile configuration, we need to support the multivalued attribute.

We now support the `multi_valued = bool` attribute.

Example:
```hcl
  attribute {
    name = "myAttr"

    multi_valued = true

    validator {
      name = "options"
      config = {
        options = jsonencode(["opt1", "opt2", "opt3"])
      }
    }

    annotations = {
      foo = jsonencode({ "key" : "val" })
    }
  }
 ```

 Fixes keycloak#1064

Signed-off-by: Thomas Darimont <[email protected]>
Signed-off-by: angeloxx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multivalued on keycloak_realm_user_profile
2 participants