[KEYCLOAK-17112] Added realm key algorithm as a config option #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@VarunPeddina indeed the Node.js adapter should support more algorithms. The changes look good, although the PR needs integration tests, otherwise we can't move forward with these changes. |
|
Hi, any visibility on this PR ? the usecase and fix is perfect, we are stuck cause RSA-SHA256 - would be perfect to have it parameterizable ! |
|
+1 |
wjh000123
approved these changes
Nov 17, 2021
wjh000123
approved these changes
Nov 17, 2021
|
@stianst tests are still missing, would you like to merge those changes without tests? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.