Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KEYCLOAK-15950] [Ankon] Added option to set config on a keycloak ins… #262

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

luciferankon
Copy link

No description provided.

@apiel
Copy link

apiel commented Jan 10, 2022

This PR is inconsistent as the config are used in the instantiation of the Keycloak object, see https://github.com/keycloak/keycloak-nodejs-connect/blob/main/keycloak.js#L61

If you would want to do something like this, you should reinitialize the whole keycloak instance or extract all the config initialization and take care that the GrantManager is properly updated. I think to do such thing, you need to do major refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants