Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KEYCLOAK-13841] Update typescript declarations #245

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ckwalsh
Copy link

@ckwalsh ckwalsh commented Apr 20, 2020

No description provided.

@Spittal
Copy link

Spittal commented Apr 24, 2020

This would solve the issue we spent hours debugging... Which is the fact that keycloak.protect() can now be invoked without a spec. As a work-around we ended up using keycloak.protect(() => true) Which is the worst.

@ckwalsh ckwalsh force-pushed the master branch 2 times, most recently from 69e896a to 4e4e160 Compare April 26, 2020 21:19
@abstractj
Copy link

@ckwalsh thanks for submitting this. The issue reported seems very close to https://issues.redhat.com/browse/KEYCLOAK-12771, which was merged to master. Could you please rebase?

@ckwalsh
Copy link
Author

ckwalsh commented Apr 28, 2020

@abstractj It mostly covers it, but I think I added a few more structs/fields. I'll rebase and see what the differences are.

@abstractj
Copy link

@Spittal once @ckwalsh push the changes to this PR. We can do another round of review.

@ckwalsh
Copy link
Author

ckwalsh commented Jul 11, 2020

Apologies for not updating this, I had work + personal stuff come up, and had set aside the project I was working on that used keybase for the moment This should now be up to date and merge safely.

@ckwalsh
Copy link
Author

ckwalsh commented Jul 11, 2020

I also just confirmed that #250 merges on top cleanly, so I don't think there is a need to merge the pull requests further.

Looking at Travis, failed checks seem to be related to the chromedriver version, and are not related to either pull request.

@jadiaheno
Copy link

Any news on that one, or any help needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants