Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile update. #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Johannestegner
Copy link
Contributor

This pull request includes the following changes:

  • The initial container creation in generate now uses a auto-removed container.
  • Instead of using a local bound volume, a persistent docker volume is attached to the containers.
  • example-keybaseca-volume was removed.
  • Readme file was added to the docker folder to describe the main tasks in the make file.
  • reset-permissions have been removed as it is no longer needed.
  • create-volume have been introduced - it creates a new persistent volume in case one with the set name does not exist.
  • clean now removes all containers using the volume and deletes the volume.
  • Some minor changes to make the output easier to read was made.

Observe!

This PR have a breaking change. The new volume does not import earlier created certificates. If one have those, the following could be used to import them into the volume (after generate).

docker run --rm -v $(pwd)/example-keybaseca-volume:/tmp -v  keybase-sshca-volume:/mnt cp /tmp/* /mnt

This should copy all the files from the old example-keybase-volume into the new persistent volume.


notice:

I was unable to run the tests locally, so if that is possible, please let me know how to. I did run the make tasks a couple of hundred times and tried to cover each possible scenario, but that might not be enough, hehe.

…s and use a volume instead of a bind-mounted host directory. Removed old example-keybaseca-volume directory and created a readme in the docker directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant