Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes the following changes:
generate
now uses a auto-removed container.example-keybaseca-volume
was removed.reset-permissions
have been removed as it is no longer needed.create-volume
have been introduced - it creates a new persistent volume in case one with the set name does not exist.clean
now removes all containers using the volume and deletes the volume.Observe!
This PR have a breaking change. The new volume does not import earlier created certificates. If one have those, the following could be used to import them into the volume (after
generate
).This should copy all the files from the old example-keybase-volume into the new persistent volume.
notice:
I was unable to run the tests locally, so if that is possible, please let me know how to. I did run the make tasks a couple of hundred times and tried to cover each possible scenario, but that might not be enough, hehe.