Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a bundle package and environment to build a basic "externals" stack #676
Add a bundle package and environment to build a basic "externals" stack #676
Changes from all commits
1f56e54
297816f
c628ddc
82a63c6
7d55297
0b4fdd5
05c4258
8e00f31
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+root7
is not a default one and is probably needed in some places, others may also be needed to prevent a dependency from needing another ROOT.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this should be covered by including the common
packages.yaml
, I think.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if changing the requirements in the common
packages.yaml
and affecting the external stack will be a problem or not 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. I think it shouldn't since the ones specified in the external environment take precedence. However, if the requirements in the common packages are underspecified, then building a
key4hep-stack
on top of the external environment might lead to some packages being rebuilt for the latter because not all variants are present.This might be something that could be checked in CI (maybe in a follow up PR): concretize this external environment and either the release or nightly environment and see if the packages that are common to both get concretized the same.