Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the commit that actually landed in upstream spack #673

Closed
wants to merge 1 commit into from

Conversation

tmadlener
Copy link
Contributor

BEGINRELEASENOTES

  • Use the spack that landed in upstream spack for py-onnx. This has the better matching criteria for when it should be applied.

ENDRELEASENOTES

After just spending about half an hour wondering why the patch that I wanted seems to not have been applied.

@jmcarcell
Copy link
Member

I'm actually not sure what to do in the rare cases where the cherry pick and what actually lands in spack differ significantly. Since the build was done with the original cherry pick I think for building with the Key4hep builds on cvmfs as an upstream the builds it is better to keep the original one, otherwise if there is any difference that changes the hash of the package rebuilds will be triggered. But if the original is kept then it's an issue for people that are building.

I'm going to close this for now since I'm going to update all the cherry picks for the nightlies that have been deployed today soon anyway.

@jmcarcell jmcarcell closed this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants