make material in 1st layer of ECAL absorber configurable #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ult to G10 rather than LAr. Also add more comments and fix some whitespaces
… by default to G10 rather than LAr. Also add more comments and fix some whitespaces" This reverts commit 33615be.
|
@BrieucF has we agreed, I moved the changes to ALLEGRO_o1_v04 |
|
Thanks Giovanni! You prefer to have the change to have all layers with the same "radial" extent in another PR? |
|
Yes let's reserve that for another PR (are we sure we want to have both changes applied in the same detector model)? |
I'd say yes, because we bump the version we can apply significant changes. And if we decide that the default in v04 is to have pre-sampler with lead, then it goes int he direction of having the first layer as a normal layer. But we can re-discuss later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make material in 1st layer of noble-liquid ECAL absorber configurable.
Set by default to G10 rather than LAr.
Also add more comments and fix some whitespaces
BEGINRELEASENOTES
ENDRELEASENOTES
Here are a couple of plots that compare cellID and energy with the previous code and with the new code when the material in 1st layer is set to LAr via xml, to confirm that the code reshuffling itself has no impact on physics