-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the possibility to set edm4hep::utils::ParticleIDMeta
via the IMetadataSvc
#273
Conversation
ff46b52
to
baecff1
Compare
I have added a "small" test case that runs similar checks as in the functional algorithm as a standalone application (effectively hard-coding the expected parameter and algorithm names). I have done it in c++ because the PIDHandler is not yet really usable in python (see key4hep/EDM4hep#396). Once the nightly builds have picked up key4hep/EDM4hep#395, CI should also start to pass again (tomorrow). |
edm4hep::utils::ParticleIDMeta
via the IMetadataSvc
edm4hep::utils::ParticleIDMeta
via the IMetadataSvc
b2dc6c8
to
60c885a
Compare
Necessary because there is a new output collection in the functional producer that is used in several places
Since I touched the |
Technically already covered via Gaudi, but this makes it explicit
I'll give this another look and update key4hep/k4MarlinWrapper#216 to use this to see if anything is missing between today and tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good related to key4hep/k4MarlinWrapper#216
Co-authored-by: Juan Miguel Carceller <[email protected]>
Merge? As a note once we stop using Ubuntu 22.04 (because there are already builds for Ubuntu 24.04, key4hep/key4hep-spack#700) we can use |
Yes, this is done from my point of view, unless someone still has comments. |
BEGINRELEASENOTES
edm4hep::utils::ParticleIDMeta
with theMetadataSvc
get
andput
that defer to the corresponding utility calls in EDM4hepENDRELEASENOTES
This would be option 1 sketched out in #272