cmake: Overhaul downstream config to properly export version and dependencies #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
force-pushed
the
cmake-config-fixes
branch
from
7dd5f8f to
886d57f
Compare
After the discussion at todays meeting it looks like k4FWCore handles all the things also for older podio versions, so we can keep the compatibility for now. |
tmadlener
force-pushed
the
cmake-config-fixes
branch
2 times, most recently
from
f09f222 to
eb6a2b7
Compare
jmcarcell
force-pushed
the
cmake-config-fixes
branch
from
eb6a2b7 to
f8b9dc6
Compare
jmcarcell
reviewed
Oct 7, 2024
jmcarcell
reviewed
Oct 8, 2024
tmadlener
force-pushed
the
cmake-config-fixes
branch
from
f8b9dc6 to
cff6168
Compare
tmadlener
changed the title
- Make sure all required dependencies are also detected in downstream users - Add some legacy variables
Move all downstream related config to one file
tmadlener
force-pushed
the
cmake-config-fixes
branch
from
1776700 to
34dd630
Compare
|
I think this is ready to be merged now. |
m-fila
reviewed
Jan 16, 2025
Co-authored-by: Mateusz Jakub Fila <[email protected]>
jmcarcell
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
k4FWCoreConfig.cmaketo put a bit more information in thereENDRELEASENOTES
There are a few things that we could also address while we are here
1.0pre-release cycle, maybe we should start to do so (and then also propagate that information to downstream consumers)Is podio 0.16.3 still something that we can use? With the addition of theMetadataSvc(Add a metadata service and a test #215 and Fix accessing input file metadata in MetadataSvc #223), I think we need at least podio 1.0 in any case.Fixes #166