Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Keep footer at bottom of viewport" #211

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

lkhrs
Copy link
Collaborator

@lkhrs lkhrs commented Oct 22, 2024

Reverts #209 to fix #210
This PR caused presentational elements directly under <body> to fill the viewport height. See PR for detailed breakdown.

Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for simplecss-cdn ready!

Name Link
🔨 Latest commit 9a55d34
🔍 Latest deploy log https://app.netlify.com/sites/simplecss-cdn/deploys/67181f0e7076030008d1b0cb
😎 Deploy Preview https://deploy-preview-211--simplecss-cdn.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lkhrs lkhrs merged commit 0d4b9f8 into main Oct 22, 2024
4 of 5 checks passed
@lkhrs lkhrs deleted the revert-209-issue206 branch November 1, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notice box sizing error
1 participant