fix: handle complex types when generating Avro values #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a new tests that didn't pass without this change? |
yvrng
force-pushed
the
feat/kafka_produce
branch
from
555d1f1
to
7670e26
Compare
|
I've added a collection of unit tests for all complex types, and for some common combinations. |
loicmathieu
approved these changes
Sep 23, 2024
Skraye
pushed a commit
that referenced
this pull request
Oct 3, 2024
* fix: handle complex types when generating Avro values * chore: add TODO comment * fix: handle null value * test: add unit tests * test: add unit tests
Skraye
pushed a commit
that referenced
this pull request
Oct 4, 2024
* fix: handle complex types when generating Avro values * chore: add TODO comment * fix: handle null value * test: add unit tests * test: add unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
Producetask, we are only able to send objects with a simple structure. The current code does not handle complex types correctly, such as enums, unions, lists, maps, etc.This commit improves handling of complex Avro types in Kafka by introducing
MapToGenericRecordSerializera betterGenericRecordserialization.Note: Further work may be required to handle fixed values (which only accept
byte[]) and unions (currently using the first non-null type, which allow support for optional values but not polymorphism).