feat(amqp): allow an incomplete URL as parameter #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchiotludo
reviewed
Dec 1, 2023
src/main/java/io/kestra/plugin/amqp/AbstractAmqpConnection.java
Outdated
Show resolved
Hide resolved
tchiotludo
requested review from
brian-mulier-p
and removed request for
tchiotludo
brian-mulier-p
requested changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of these changes is to allow the definition of credentials from a secret manager. The URL can stay clear in K8s configuration, and credentials are often split as a key/value pair.