Fixes #769 - Replace Variant Autoloader #770
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Play A Game Against Bots" → "Play a game against bots"
"Play A Game Against Humans" → "Play a game against humans"
Pull new version across to live with game message phase data and user opt in features
Added game message phase marker
Bug fix for update SQL
less unnecessary and excessive capitalization
…ssage_api Return timesent in api
Changed donation button to pay in USD, have more modern styling, and go straight to the WebDiplomacy Pty Ltd PayPal. (Note that this used to be defined in config.php so it could be changed per-site, it would be good to restore this functionality since this is specific to our installation.)
Changed to embed user id in case paypal email doesn't match user email
Thank you blurb
Fixes a double SQL operation in Full Install SQL script
Fix fullInstall.sql, thanks
…cated `__autoload` method.
|
Hi Jim,
Don’t suppose you could to a PR against the staging branch first? That way I can just check there are no issues on test.WebDiplomacy.net before publishing live. (Got burned last week.)
Thanks for the fix.
Rgds,
Chris
Regards,
…________________________________
From: Jim Mackin ***@***.***>
Sent: Monday, April 11, 2022 8:09:06 PM
To: kestasjk/webDiplomacy ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [kestasjk/webDiplomacy] Fixes #769 - Replace Variant Autoloader (PR #770)
Use spl_autoload_register instead of the deprecated _autoload method.
________________________________
You can view, comment on, or merge this pull request online at:
#770
Commit Summary
* 65b1a98<65b1a98> Fixes #769 - Use `spl_autoload_register` instead of the deprecated `__autoload` method.
File Changes
(1 file<https://github.com/kestasjk/webDiplomacy/pull/770/files>)
* M variants/variant.php<https://github.com/kestasjk/webDiplomacy/pull/770/files#diff-e8f44586b12cd5ebce8df6c476ea8b8e0205dec476eba4b207dc88ecee611b72> (5)
Patch Links:
* https://github.com/kestasjk/webDiplomacy/pull/770.patch
* https://github.com/kestasjk/webDiplomacy/pull/770.diff
—
Reply to this email directly, view it on GitHub<#770>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAH2GTJBGTSCLJ7FZIXHR5LVEQI6FANCNFSM5TC7C6KQ>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
Yep, makes sense. Will do that now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
spl_autoload_registerinstead of the deprecated_autoloadmethod.